refactor: address quality issues

Author: mariajgrimaldi

openedx_authz/api/roles.py

@@ -242,7 +242,7 @@ def assign_role_to_subject_in_scope(subject: SubjectData, role: RoleData, scope:
                 subject=subject.namespaced_key,
                 role=role.namespaced_key,
                 scope=scope.namespaced_key,
-                actor=getattr(get_current_user(), "username", None)
+                actor=getattr(get_current_user(), "username", None),
             )
         )
     )
@@ -293,7 +293,7 @@ def unassign_role_from_subject_in_scope(subject: SubjectData, role: RoleData, sc
                     subject=subject.namespaced_key,
                     role=role.namespaced_key,
                     scope=scope.namespaced_key,
-                    actor=getattr(get_current_user(), "username", None)
+                    actor=getattr(get_current_user(), "username", None),
                 )
             )
         )
@@ -613,6 +613,5 @@ def get_all_role_assignments_per_scope_type(scope_types: tuple[type[ScopeData],
         list[RoleAssignmentData]: All assignments whose scope is an instance of any of the given scope types.
     """
     return [
-        role_assignment for role_assignment in get_role_assignments()
-        if isinstance(role_assignment.scope, scope_types)
+        role_assignment for role_assignment in get_role_assignments() if isinstance(role_assignment.scope, scope_types)
     ]

openedx_authz/engine/utils.py

@@ -264,8 +264,7 @@ def migrate_legacy_course_roles_to_authz(course_access_role_model, course_id_lis
 
         # Permission applied to individual user
         logger.info(
-            f"Migrating permission for User: {permission.user.username} "
-            f"to Role: {role} in Scope: {scope_external_key}"
+            f"Migrating permission for User: {permission.user.username} to Role: {role} in Scope: {scope_external_key}"
         )
 
         is_user_added = assign_role_to_user_in_scope(
@@ -322,25 +321,26 @@ def migrate_authz_to_legacy_course_roles(
     _validate_migration_input(course_id_list, org_id)
 
     role_assignments = get_all_role_assignments_per_scope_type(
-        scope_types=(CourseOverviewData, OrgCourseOverviewGlobData,)
+        scope_types=(
+            CourseOverviewData,
+            OrgCourseOverviewGlobData,
+        )
     )
 
     # Two cases here:
     # 1. org_id provided: filter by org — includes org-level glob and course-level scopes for that org.
     # 2. only course_id_list provided: filter by course_id — org-level glob scopes are excluded (no course_id).
     if org_id:
         role_assignments = [
-            role_assignment
-            for role_assignment in role_assignments
-            if role_assignment.scope.org == org_id
+            role_assignment for role_assignment in role_assignments if role_assignment.scope.org == org_id
         ]
 
     if course_id_list and not org_id:
         role_assignments = [
             role_assignment
             for role_assignment in role_assignments
-            if isinstance(role_assignment.scope, CourseOverviewData) and
-            role_assignment.scope.course_id in course_id_list
+            if isinstance(role_assignment.scope, CourseOverviewData)
+            and role_assignment.scope.course_id in course_id_list
         ]
 
     roles_with_errors = []
@@ -350,13 +350,10 @@ def migrate_authz_to_legacy_course_roles(
     user_external_keys = {assignment.subject.external_key for assignment in role_assignments}
     users_by_username = {
         subject.user.username: subject.user
-        for subject in user_subject_model.objects.filter(
-            user__username__in=user_external_keys
-        ).select_related("user")
+        for subject in user_subject_model.objects.filter(user__username__in=user_external_keys).select_related("user")
     }
 
     for role_assignment in role_assignments:
-
         # Per valid role assignment, create corresponding CourseAccessRole entry
         # depending on whether the scope is course-level or org-level glob
         try:

openedx_authz/migrations/0008_roleassignmentaudit.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("openedx_authz", "0007_coursescope"),
     ]
@@ -47,8 +46,7 @@ class Migration(migrations.Migration):
                     "scope",
                     models.CharField(
                         help_text=(
-                            "Namespaced key of the scope"
-                            " (e.g. 'course-v1^course-v1:org+course+run') or glob pattern."
+                            "Namespaced key of the scope (e.g. 'course-v1^course-v1:org+course+run') or glob pattern."
                         ),
                         max_length=255,
                     ),
@@ -58,8 +56,7 @@ class Migration(migrations.Migration):
                     models.CharField(
                         blank=True,
                         help_text=(
-                            "Username of the user who performed the operation,"
-                            " or None for system-initiated actions."
+                            "Username of the user who performed the operation, or None for system-initiated actions."
                         ),
                         max_length=150,
                         null=True,

openedx_authz/models/core.py

@@ -12,6 +12,7 @@
 from openedx_authz.constants import AUTHZ_POLICY_ATTRIBUTES_SEPARATOR
 from openedx_authz.engine.filter import Filter
 
+
 class BaseRegistryModel(models.Model):
     """Base model that supports automatic subclass registration.
 

openedx_authz/tests/test_migrations.py

@@ -1301,9 +1301,7 @@ def test_migrate_org_level_scope_creates_org_glob_assignment(self):
         AuthzEnforcer.get_enforcer().load_policy()
 
         org_scope = OrgCourseOverviewGlobData.build_external_key(org_short_name_new)
-        assignments = get_user_role_assignments_in_scope(
-            user_external_key=user.username, scope_external_key=org_scope
-        )
+        assignments = get_user_role_assignments_in_scope(user_external_key=user.username, scope_external_key=org_scope)
         self.assertEqual(len(assignments), 1)
         self.assertEqual(assignments[0].roles[0], COURSE_ADMIN)
 
@@ -1404,8 +1402,7 @@ def test_course_id_list_filter_excludes_glob_and_other_courses(self):
         AuthzEnforcer.get_enforcer().load_policy()
 
         errors, successes = migrate_authz_to_legacy_course_roles(
-            CourseAccessRole, UserSubject,
-            course_id_list=[self.course_id], org_id=None, delete_after_migration=False
+            CourseAccessRole, UserSubject, course_id_list=[self.course_id], org_id=None, delete_after_migration=False
         )
 
         migrated_users = {assignment.subject.external_key for assignment in successes}