refactor: address PR reviews

mariajgrimaldi · mariajgrimaldi · commit 50781e6d3f07 · 2026-04-09T15:11:36.000+02:00
diff --git a/openedx_authz/engine/utils.py b/openedx_authz/engine/utils.py
@@ -327,8 +327,7 @@ def migrate_authz_to_legacy_course_roles(
         role_assignments = [
             role_assignment
             for role_assignment in role_assignments
-            if isinstance(role_assignment.scope, CourseOverviewData)
-            and role_assignment.scope.external_key in course_id_list
+            if role_assignment.scope.course_id in course_id_list
         ]
 
     roles_with_errors = []

Original file line number	Diff line number	Diff line change
`@@ -327,8 +327,7 @@ def migrate_authz_to_legacy_course_roles(`
`327`	`327`	`role_assignments = [`
`328`	`328`	`role_assignment`
`329`	`329`	`for role_assignment in role_assignments`
`330`		`- if isinstance(role_assignment.scope, CourseOverviewData)`
`331`		`- and role_assignment.scope.external_key in course_id_list`
	`330`	`+ if role_assignment.scope.course_id in course_id_list`
`332`	`331`	`]`
`333`	`332`
`334`	`333`	`roles_with_errors = []`