Skip to content

Commit 4a84f7c

Browse files
mariajgrimaldiBryanttV
authored andcommitted
fix: address quality errors
1 parent 3c637f8 commit 4a84f7c

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

openedx_authz/engine/utils.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -324,9 +324,8 @@ def migrate_authz_to_legacy_course_roles(
324324
role_assignments = get_all_role_assignments_per_scope_type(scope_type=CourseOverviewData)
325325

326326
# Two cases here:
327-
# 1. If org_id is provided, we filter by org_id which will include both org-level glob scopes and course-level scopes linked to that org
328-
# 2. If only course_id_list is provided, we filter by course_id which will include only course-level scopes linked to those course_ids since
329-
# org-level glob scopes don't have course_id in their scope object
327+
# 1. org_id provided: filter by org — includes org-level glob and course-level scopes for that org.
328+
# 2. only course_id_list provided: filter by course_id — org-level glob scopes are excluded (no course_id).
330329
if org_id:
331330
role_assignments = [
332331
role_assignment
@@ -385,7 +384,7 @@ def migrate_authz_to_legacy_course_roles(
385384
if delete_after_migration:
386385
unassignments[(role_external_key, scope_external_key)].append(user_external_key)
387386

388-
except Exception as e:
387+
except Exception as e: # pylint: disable=broad-exception-caught
389388
logger.error(
390389
f"Error rolling back RoleAssignment for User: {role_assignment.subject.external_key} "
391390
f"in Role: {role_assignment.roles[0].external_key} and Scope: {role_assignment.scope.external_key}: {e}"

0 commit comments

Comments
 (0)