squash!: Improve namings

Author: rodmgwgu

openedx_authz/api/users.py

@@ -50,15 +50,15 @@
     "get_user_role_assignments",
     "get_user_role_assignments_in_scope",
     "get_user_role_assignments_for_role_in_scope",
-    "get_user_role_assignments_for_user_filtered",
     "get_user_role_assignments_filtered",
     "get_all_user_role_assignments_in_scope",
     "get_visible_role_assignments_for_user",
+    "get_visible_specific_user_role_assignments_for_user",
     "is_user_allowed",
     "get_scopes_for_user_and_permission",
     "get_users_for_role_in_scope",
     "unassign_all_roles_from_user",
-    "get_superadmins",
+    "get_superadmin_assignments",
 ]
 
 
@@ -176,7 +176,7 @@ def get_user_role_assignments_for_role_in_scope(
     )
 
 
-def get_user_role_assignments_for_user_filtered(
+def get_visible_specific_user_role_assignments_for_user(
     user_external_key: str,
     orgs: list[str] = None,
     roles: list[str] = None,
@@ -385,7 +385,7 @@ def unassign_all_roles_from_user(user_external_key: str) -> bool:
     return unassign_subject_from_all_roles(UserData(external_key=user_external_key))
 
 
-def get_superadmins(user_external_keys: list[str] | None = None) -> list[SuperAdminAssignmentData]:
+def get_superadmin_assignments(user_external_keys: list[str] | None = None) -> list[SuperAdminAssignmentData]:
     """Returns all superadmins as SuperAdminAssignmentData.
 
     A superadmin is a User with a Django staff or superuser role.

openedx_authz/rest_api/v1/views.py

@@ -21,7 +21,7 @@
 
 from openedx_authz import api
 from openedx_authz.api.data import RoleAssignmentData, SuperAdminAssignmentData
-from openedx_authz.api.users import get_superadmins, get_user_role_assignments_for_user_filtered
+from openedx_authz.api.users import get_superadmin_assignments, get_visible_specific_user_role_assignments_for_user
 from openedx_authz.api.utils import get_user_map
 from openedx_authz.constants import permissions
 from openedx_authz.rest_api.data import RoleOperationError, RoleOperationStatus
@@ -633,9 +633,9 @@ def get(self, request: HttpRequest, username: str) -> Response:
         user_role_assignments: list[RoleAssignmentData | SuperAdminAssignmentData] = []
 
         # Retrieve superadmin assignments (django staff or superuser users), as they always have access to everything
-        user_role_assignments += get_superadmins(user_external_keys=[username])
+        user_role_assignments += get_superadmin_assignments(user_external_keys=[username])
 
-        user_role_assignments += get_user_role_assignments_for_user_filtered(
+        user_role_assignments += get_visible_specific_user_role_assignments_for_user(
             user_external_key=username,
             orgs=query_params.get("orgs"),
             roles=query_params.get("roles"),