Skip to content

Commit 39b4a9c

Browse files
committed
refactor: simplify validated_scopes list in AddUsersToRoleWithScopeSerializer
1 parent 0a57aa2 commit 39b4a9c

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

openedx_authz/rest_api/v1/serializers.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ def validate(self, attrs) -> dict:
160160
"Either 'scope' or 'scopes' must be provided."
161161
)
162162

163-
validated_scopes = []
164163
for scope_value in scopes_list:
165164
try:
166165
scope_obj = api.ScopeData(external_key=scope_value)
@@ -179,10 +178,8 @@ def validate(self, attrs) -> dict:
179178
{"role": f"Role '{role_value}' does not exist in scope '{scope_value}'"}
180179
)
181180

182-
validated_scopes.append(scope_value)
183-
184181
validated_data.pop("scope", None)
185-
validated_data["scopes"] = validated_scopes
182+
validated_data["scopes"] = scopes_list
186183
return validated_data
187184

188185

0 commit comments

Comments
 (0)