Skip to content

Commit 34e76de

Browse files
committed
refactor: simplify validated_scopes list in AddUsersToRoleWithScopeSerializer
1 parent 161d276 commit 34e76de

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

openedx_authz/rest_api/v1/serializers.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ def validate(self, attrs) -> dict:
146146
"Either 'scope' or 'scopes' must be provided."
147147
)
148148

149-
validated_scopes = []
150149
for scope_value in scopes_list:
151150
try:
152151
scope_obj = api.ScopeData(external_key=scope_value)
@@ -165,10 +164,8 @@ def validate(self, attrs) -> dict:
165164
{"role": f"Role '{role_value}' does not exist in scope '{scope_value}'"}
166165
)
167166

168-
validated_scopes.append(scope_value)
169-
170167
validated_data.pop("scope", None)
171-
validated_data["scopes"] = validated_scopes
168+
validated_data["scopes"] = scopes_list
172169
return validated_data
173170

174171

0 commit comments

Comments
 (0)