refactor: address PR reviews

mariajgrimaldi · mariajgrimaldi · commit 28791a6ce0b8 · 2026-04-10T11:54:54.000+02:00
diff --git a/openedx_authz/engine/utils.py b/openedx_authz/engine/utils.py
@@ -337,8 +337,7 @@ def migrate_authz_to_legacy_course_roles(
         role_assignments = [
             role_assignment
             for role_assignment in role_assignments
-            if isinstance(role_assignment.scope, CourseOverviewData)
-            and role_assignment.scope.external_key in course_id_list
+            if role_assignment.scope.course_id in course_id_list
         ]
 
     roles_with_errors = []

Original file line number	Diff line number	Diff line change
`@@ -337,8 +337,7 @@ def migrate_authz_to_legacy_course_roles(`
`337`	`337`	`role_assignments = [`
`338`	`338`	`role_assignment`
`339`	`339`	`for role_assignment in role_assignments`
`340`		`- if isinstance(role_assignment.scope, CourseOverviewData)`
`341`		`- and role_assignment.scope.external_key in course_id_list`
	`340`	`+ if role_assignment.scope.course_id in course_id_list`
`342`	`341`	`]`
`343`	`342`
`344`	`343`	`roles_with_errors = []`