refactor: remove unused role assignment functions from user and roles api

Author: BryanttV

openedx_authz/api/roles.py

@@ -410,23 +410,6 @@ def get_subject_role_assignments_in_scope(subject: SubjectData, scope: ScopeData
     return role_assignments
 
 
-def get_subject_role_assignments_for_role(subject: SubjectData, role: RoleData) -> list[RoleAssignmentData]:
-    """Get role assignments for a subject filtered by a specific role across all scopes.
-
-    Args:
-        subject: The SubjectData object representing the subject.
-        role: The RoleData object representing the role to filter by.
-
-    Returns:
-        list[RoleAssignmentData]: A list of assignments where the subject has the specified role.
-    """
-    return [
-        assignment
-        for assignment in get_subject_role_assignments(subject)
-        if any(assigned_role.namespaced_key == role.namespaced_key for assigned_role in assignment.roles)
-    ]
-
-
 def get_subject_role_assignments_for_role_in_scope(role: RoleData, scope: ScopeData) -> list[RoleAssignmentData]:
     """Get the subjects assigned to a specific role in a specific scope.
 

openedx_authz/api/users.py

@@ -26,7 +26,6 @@
     get_role_assignments,
     get_scopes_for_subject_and_permission,
     get_subject_role_assignments,
-    get_subject_role_assignments_for_role,
     get_subject_role_assignments_for_role_in_scope,
     get_subject_role_assignments_in_scope,
     get_subjects_for_role_in_scope,
@@ -48,7 +47,6 @@
     "get_scopes_for_user_and_permission",
     "get_users_for_role_in_scope",
     "unassign_all_roles_from_user",
-    "get_user_role_assignments_for_role",
 ]
 
 
@@ -132,22 +130,6 @@ def get_user_role_assignments(user_external_key: str) -> list[RoleAssignmentData
     return get_subject_role_assignments(UserData(external_key=user_external_key))
 
 
-def get_user_role_assignments_for_role(user_external_key: str, role_external_key: str) -> list[RoleAssignmentData]:
-    """Get role assignments for a user filtered by a specific role across all scopes.
-
-    Args:
-        user_external_key (str): ID of the user (e.g., 'john_doe').
-        role_external_key (str): Name of the role (e.g., 'instructor').
-
-    Returns:
-        list[RoleAssignmentData]: A list of role assignments for the given user and role.
-    """
-    return get_subject_role_assignments_for_role(
-        UserData(external_key=user_external_key),
-        RoleData(external_key=role_external_key),
-    )
-
-
 def get_user_role_assignments_in_scope(user_external_key: str, scope_external_key: str) -> list[RoleAssignmentData]:
     """Get the roles assigned to a user in a specific scope.
 

openedx_authz/tests/api/test_roles.py

@@ -31,7 +31,6 @@
     get_role_definitions_in_scope,
     get_scopes_for_subject_and_permission,
     get_subject_role_assignments,
-    get_subject_role_assignments_for_role,
     get_subject_role_assignments_for_role_in_scope,
     get_subject_role_assignments_in_scope,
     get_subjects_for_role_in_scope,
@@ -604,23 +603,6 @@ def test_get_all_role_assignments_scopes(self, subject_name, expected_roles):
             found = any(expected_role in assignment.roles for assignment in role_assignments)
             self.assertTrue(found, f"Expected role {expected_role} not found in assignments")
 
-    @ddt_data(
-        ("liam", roles.LIBRARY_AUTHOR.external_key, 3),
-        ("eve", roles.LIBRARY_ADMIN.external_key, 1),
-        ("eve", roles.LIBRARY_AUTHOR.external_key, 1),
-        ("eve", roles.LIBRARY_USER.external_key, 1),
-        ("alice", roles.LIBRARY_AUTHOR.external_key, 0),
-        ("non_existent_user", roles.LIBRARY_ADMIN.external_key, 0),
-    )
-    @unpack
-    def test_get_subject_role_assignments_for_role(self, subject_name, role_name, expected_count):
-        """Test retrieving role assignments for a subject filtered by role across all scopes."""
-        role_assignments = get_subject_role_assignments_for_role(
-            SubjectData(external_key=subject_name),
-            RoleData(external_key=role_name),
-        )
-        self.assertEqual(len(role_assignments), expected_count)
-
     @ddt_data(
         (roles.LIBRARY_ADMIN.external_key, "lib:Org1:math_101", 1),
         (roles.LIBRARY_AUTHOR.external_key, "lib:Org1:history_201", 1),

openedx_authz/tests/api/test_users.py

@@ -9,7 +9,6 @@
     batch_unassign_role_from_users,
     get_all_user_role_assignments_in_scope,
     get_user_role_assignments,
-    get_user_role_assignments_for_role,
     get_user_role_assignments_for_role_in_scope,
     get_user_role_assignments_in_scope,
     is_user_allowed,
@@ -53,39 +52,6 @@ def _assign_roles_to_users(
 class TestUserRoleAssignments(UserAssignmentsSetupMixin):
     """Test suite for user-role assignment API functions."""
 
-    @data(
-        ("alice", roles.LIBRARY_ADMIN.external_key, 1, {"lib:Org1:math_101"}),
-        ("eve", roles.LIBRARY_ADMIN.external_key, 1, {"lib:Org2:physics_401"}),
-        (
-            "liam",
-            roles.LIBRARY_AUTHOR.external_key,
-            3,
-            {"lib:Org4:art_101", "lib:Org4:art_201", "lib:Org4:art_301"},
-        ),
-        ("alice", roles.LIBRARY_AUTHOR.external_key, 0, set()),
-        ("non_existent_user", roles.LIBRARY_ADMIN.external_key, 0, set()),
-    )
-    @unpack
-    def test_get_user_role_assignments_for_role(
-        self,
-        username,
-        role_external_key,
-        expected_count,
-        expected_scopes,
-    ):
-        role_assignments = get_user_role_assignments_for_role(
-            user_external_key=username,
-            role_external_key=role_external_key,
-        )
-
-        self.assertEqual(len(role_assignments), expected_count)
-
-        role_names = {r.external_key for assignment in role_assignments for r in assignment.roles}
-        self.assertEqual(role_names, set() if expected_count == 0 else {role_external_key})
-
-        scopes = {assignment.scope.external_key for assignment in role_assignments}
-        self.assertEqual(scopes, expected_scopes)
-
     @data(
         ("john", roles.LIBRARY_ADMIN.external_key, "lib:Org1:math_101", False),
         ("jane", roles.LIBRARY_USER.external_key, "lib:Org1:english_101", False),