refactor: address PR review

Author: mariajgrimaldi

openedx_authz/api/roles.py

@@ -40,7 +40,7 @@
     "get_subject_role_assignments_for_role_in_scope",
     "get_all_subject_role_assignments_in_scope",
     "get_subject_role_assignments",
-    "unassign_subjects_from_all_roles",
+    "unassign_subject_from_all_roles",
 ]
 
 # TODO: these are the concerns we still have to address:
@@ -393,7 +393,7 @@ def get_subjects_for_role(role: RoleData) -> list[SubjectData]:
     return [SubjectData(namespaced_key=policy[GroupingPolicyIndex.SUBJECT.value]) for policy in policies]
 
 
-def unassign_subjects_from_all_roles(subject: SubjectData) -> bool:
+def unassign_subject_from_all_roles(subject: SubjectData) -> bool:
     """Unassign a subject from all roles across all scopes.
 
     Args:

openedx_authz/api/users.py

@@ -21,7 +21,7 @@
     get_subject_role_assignments_in_scope,
     get_subjects_for_role,
     unassign_role_from_subject_in_scope,
-    unassign_subjects_from_all_roles,
+    unassign_subject_from_all_roles,
 )
 
 __all__ = [
@@ -211,4 +211,4 @@ def unassign_all_roles_from_user(user_external_key: str) -> bool:
     Returns:
         bool: True if any roles were removed, False otherwise.
     """
-    return unassign_subjects_from_all_roles(UserData(external_key=user_external_key))
+    return unassign_subject_from_all_roles(UserData(external_key=user_external_key))

openedx_authz/tests/api/test_roles.py

@@ -24,7 +24,7 @@
     get_subject_role_assignments_for_role_in_scope,
     get_subject_role_assignments_in_scope,
     unassign_role_from_subject_in_scope,
-    unassign_subjects_from_all_roles,
+    unassign_subject_from_all_roles,
 )
 from openedx_authz.engine.enforcer import AuthzEnforcer
 from openedx_authz.engine.utils import migrate_policy_between_enforcers
@@ -773,7 +773,7 @@ def test_get_all_role_assignments_in_scope(self, scope_name, expected_assignment
     def test_unassign_subject_from_all_roles_removes_all_assignments(
         self, subject_name, scopes, expected_roles_before
     ):
-        """Test that unassign_subjects_from_all_roles removes all role assignments.
+        """Test that unassign_subject_from_all_roles removes all role assignments.
 
         Expected result:
             - Before unassignment: Subject has roles in specified scopes
@@ -801,7 +801,7 @@ def test_unassign_subject_from_all_roles_removes_all_assignments(
             self.assertGreater(len(scope_assignments), 0)
 
         # Unassign all roles from the subject
-        result = unassign_subjects_from_all_roles(subject)
+        result = unassign_subject_from_all_roles(subject)
 
         # Verify the function returns True (indicating roles were removed)
         self.assertTrue(result)
@@ -831,7 +831,7 @@ def test_unassign_subject_with_no_roles_returns_false(self):
         self.assertEqual(len(assignments_before), 0)
 
         # Unassign all roles (should return False since there are none)
-        result = unassign_subjects_from_all_roles(non_existent_subject)
+        result = unassign_subject_from_all_roles(non_existent_subject)
 
         # Verify the function returns False (no roles to remove)
         self.assertFalse(result)
@@ -864,7 +864,7 @@ def test_unassign_subject_does_not_affect_other_subjects(self):
         self.assertGreater(len(heidi_assignments_before), 0)
 
         # Unassign all roles from grace
-        result = unassign_subjects_from_all_roles(subject_to_unassign)
+        result = unassign_subject_from_all_roles(subject_to_unassign)
         self.assertTrue(result)
 
         # Verify grace has no assignments after unassignment
@@ -904,7 +904,7 @@ def test_unassign_and_reassign_subject(self):
         self.assertGreater(len(assignments_before), 0)
 
         # Unassign all roles
-        result = unassign_subjects_from_all_roles(subject)
+        result = unassign_subject_from_all_roles(subject)
         self.assertTrue(result)
 
         # Verify no roles after unassignment