refactor: address quality issues after rebase

Author: mariajgrimaldi

openedx_authz/api/roles.py

@@ -419,7 +419,6 @@ def get_scopes_for_subject_and_permission(
             if permission in role.permissions and role_assignment.scope not in scopes:
                 scopes.append(role_assignment.scope)
     return scopes
-    return [SubjectData(namespaced_key=policy[GroupingPolicyIndex.SUBJECT.value]) for policy in policies]
 
 
 def unassign_subject_from_all_roles(subject: SubjectData) -> bool:

openedx_authz/handlers.py

@@ -56,8 +56,9 @@ def delete_casbin_rule_on_extended_rule_deletion(sender, instance, **kwargs):  #
         )
 
 
-def unassign_roles_on_user_retirement(sender, user, **kwargs):
-    """Unassign roles from a user when they are retired.
+def unassign_roles_on_user_retirement(sender, user, **kwargs):  # pylint: disable=unused-argument
+    """
+    Unassign roles from a user when they are retired.
 
     This handler is triggered when a user is retired in the LMS. It ensures that
     any roles assigned to the user are removed, maintaining the integrity of the
@@ -70,7 +71,7 @@ def unassign_roles_on_user_retirement(sender, user, **kwargs):
     """
     try:
         unassign_all_roles_from_user(user.username)
-    except Exception as exc:
+    except Exception as exc:  # pylint: disable=broad-exception-caught
         logger.exception(
             "Error unassigning roles from user %s during retirement",
             user.id,

openedx_authz/tests/api/test_roles.py

@@ -1105,7 +1105,6 @@ def test_unassign_and_reassign_subject(self):
             - Newly assigned roles work correctly
         """
         subject = SubjectData(external_key="bob")
-        original_scope = ScopeData(external_key="lib:Org1:history_201")
         new_scope = ScopeData(external_key="lib:Org1:new_library")
         new_role = RoleData(external_key="library_admin")
 

openedx_authz/tests/integration/test_handlers.py

@@ -9,7 +9,7 @@
 
 from django.contrib.auth import get_user_model
 from django.test import TestCase
-from openedx.core.djangoapps.user_api.accounts.signals import USER_RETIRE_LMS_CRITICAL
+from openedx.core.djangoapps.user_api.accounts.signals import USER_RETIRE_LMS_CRITICAL  # pylint: disable=import-error
 
 from openedx_authz.api.data import UserData
 from openedx_authz.api.users import (