Skip to content

feat: add deprecation warning to create legacy library form [FC-0123]#2963

Merged
ChrisChV merged 2 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4333/create-legacy-lib-warning
Mar 30, 2026
Merged

feat: add deprecation warning to create legacy library form [FC-0123]#2963
ChrisChV merged 2 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4333/create-legacy-lib-warning

Conversation

@rpenido
Copy link
Copy Markdown
Contributor

@rpenido rpenido commented Mar 27, 2026

Description

Adds the following warning banner to the Create Legacy Library page:
image

Useful information to include:

  • Which user roles will this change impact?
    "Course Author"

Supporting information

Testing instructions

  • Open the Create Legacy library form (Legacy Libraries > + New Library) and check the warning

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

Private ref: FAL-4333

@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Mar 27, 2026

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 27, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Mar 27, 2026
@rpenido rpenido changed the title Rpenido/fal 4333/create legacy lib warning feat: add deprecation warning to create legacy library form [FC-0123] Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.56%. Comparing base (d0d593e) to head (128e5c4).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2963    +/-   ##
========================================
  Coverage   95.56%   95.56%            
========================================
  Files        1350     1350            
  Lines       31128    31129     +1     
  Branches     6817     7052   +235     
========================================
+ Hits        29747    29748     +1     
  Misses       1331     1331            
  Partials       50       50            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido marked this pull request as ready for review March 27, 2026 19:03
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Mar 27, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Mar 27, 2026
Copy link
Copy Markdown
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good.

Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChrisChV ChrisChV merged commit 448fcad into openedx:master Mar 30, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Mar 30, 2026
@rpenido rpenido deleted the rpenido/fal-4333/create-legacy-lib-warning branch April 8, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants