Libraries cannot be created except by global staff

[kdmccormick]

Steps to reproduce

• Create a non-admin user
• Have them request course-creator permissions in studio
• Use an admin account to go to the Course Creator page and mark their request Approved, with access to All Organizations
• Ensure there's at least one organization on the instance
• As the non-admin user, go to Studio. Notice that:
  • You can create a course, selecting the existing org from the drop-down ✅
  • But you can't create a beta library, because the organization drop-down says "Require Field" even when it's filled in ❌ 🐞
  • Same behavior when trying to create a legacy library ❌ 🐞
• Finally, as an admin user, go to Studio. Notice that you create all 3 of the above without issue ✅

Notes

I recall this same bug happening on the course-creation page when the Authoring MFE was rolled out. I recall there being a lot of discussion on how to fix the organization selection drop-down so that it worked regardless of (a) the ORGANIZATION_AUTOCREATE setting and (b) the user's creation permissions, which might be global or org-specific.

Seems like the fixes to the drop down didn't make it over to the new Libraries (Beta) creation page. Also, the Legacy Libraries creation page was recently ported to the MFE (by me) and it's entirely based on the Libraries (Beta) creation page, so it's unsurprising that the same bug is there too.

So, the fix I'd suggest is to study the org dropdown on the Course creation tab, see what is making that work, and then porting that over to both Library tabs.

Screenshots

Trying to create a beta library in an existing org

Trying to create a legacy library in an existing org

Successfully creating a course in an existing org

[kdmccormick]

Seems like this bug manifest sometimes and doesn't manifest other times, in a way I haven't been able to pinpoint.

There's a little suggestion box that pops down from the Organization field sometimes, showing the organizations you have access to. If it shows up and you select an organization from there, then you're allowed to create a course. So, maybe the bug is just that the suggestion box doesn't always show up when it should?

[jmakowski1123]

I experienced the same thing when replicating this test.

I also tried doing this test a different way, by creating the non-admin account, then going in through the admin account via django and giving the non-admin account staff status (but not global admin status). That way worked and the non-admin account was able to create a library with no problem. More evidence that the issue may lie with the org dropdown/suggestion box?

[ormsbee]

I think this is an underlying issue in edx-platform where if the ENABLE_ORGANIZATION_STAFF_ACCESS_FOR_CONTENT_LIBRARIES feature toggle is enabled, it short-circuits and ignores creator groups:

https://github.com/openedx/edx-platform/blob/2c53232c5d939bc6f340b762a7c0f685175ad542/cms/djangoapps/contentstore/views/course.py#L1826-L1829

Making a fix shortly...

[ormsbee]

Fix verified on the Ulmo sandbox.