Skip to content

fix: migrate library alert text [FC-0112]#2651

Merged
ChrisChV merged 1 commit intoopenedx:masterfrom
open-craft:rpenido/fal-4270/fix-migrate-library-alert-text
Nov 18, 2025
Merged

fix: migrate library alert text [FC-0112]#2651
ChrisChV merged 1 commit intoopenedx:masterfrom
open-craft:rpenido/fal-4270/fix-migrate-library-alert-text

Conversation

@rpenido
Copy link
Copy Markdown
Contributor

@rpenido rpenido commented Nov 14, 2025

Description

This PR updates the alert texts on the Migrate Libraries Stepper.

Destination

Image

Confirm

Image

Useful information to include:

  • Which user roles will this change impact?
    "Course Author"

Supporting information

Testing instructions

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

Private ref: FAL-4270

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 14, 2025
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Nov 14, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@rpenido rpenido marked this pull request as ready for review November 14, 2025 17:19
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Nov 14, 2025
@rpenido rpenido force-pushed the rpenido/fal-4270/fix-migrate-library-alert-text branch from 40c5dce to 6b230b3 Compare November 14, 2025 17:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.83%. Comparing base (daed664) to head (f49a777).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2651   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files        1234     1234           
  Lines       27764    27764           
  Branches     6263     6266    +3     
=======================================
  Hits        26331    26331           
- Misses       1362     1375   +13     
+ Partials       71       58   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido requested a review from navinkarkera November 17, 2025 17:58
@rpenido rpenido force-pushed the rpenido/fal-4270/fix-migrate-library-alert-text branch from 6b230b3 to f49a777 Compare November 17, 2025 20:06
Copy link
Copy Markdown
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good. Thank you! 👍

  • I tested this: (Verified the alert change locally)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@ChrisChV ChrisChV merged commit 650bb62 into openedx:master Nov 18, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Nov 18, 2025
@ChrisChV ChrisChV deleted the rpenido/fal-4270/fix-migrate-library-alert-text branch November 18, 2025 17:09
@ChrisChV
Copy link
Copy Markdown
Contributor

ChrisChV commented Dec 2, 2025

Hi @rpenido, is there a backport for this PR?

@rpenido
Copy link
Copy Markdown
Contributor Author

rpenido commented Dec 2, 2025

No @ChrisChV. I can do it tomorrow. Thanks for catching it!

@rpenido
Copy link
Copy Markdown
Contributor Author

rpenido commented Dec 3, 2025

Done @ChrisChV: #2727

ChrisChV pushed a commit that referenced this pull request Dec 4, 2025
papphelix pushed a commit to edx/frontend-app-authoring that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants