fix: migrate library alert text [FC-0112]#2651
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
40c5dce to
6b230b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2651 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 1234 1234
Lines 27764 27764
Branches 6263 6266 +3
=======================================
Hits 26331 26331
- Misses 1362 1375 +13
+ Partials 71 58 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6b230b3 to
f49a777
Compare
navinkarkera
left a comment
There was a problem hiding this comment.
@rpenido Looks good. Thank you! 👍
- I tested this: (Verified the alert change locally)
- I read through the code
- I checked for accessibility issues
- Includes documentation
|
Hi @rpenido, is there a backport for this PR? |
|
No @ChrisChV. I can do it tomorrow. Thanks for catching it! |
Description
This PR updates the alert texts on the Migrate Libraries Stepper.
Destination
Confirm
Useful information to include:
"Course Author"
Supporting information
Testing instructions
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'Private ref: FAL-4270