fix: saving alert doesn't disappear even its saved#2646
fix: saving alert doesn't disappear even its saved#2646Faraz32123 wants to merge 1 commit intomasterfrom
Conversation
saving alert doesn't disappear even if its saved and keep showing loading status
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2646 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 1231 1231
Lines 27629 27629
Branches 6221 6239 +18
=======================================
Hits 26199 26199
Misses 1359 1359
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR is making the same fix as #2614 . Please see my comment there - we just need this to fix it: - isLoading: savePending,
+ isPending: savePending,The problem is this file is not using TypeScript so nobody noticed that |
Ohk, perfect. In that case, I'll close this one. |
Saving alert doesn't disappear even if its saved and keep showing loading status.
Before:
This saving loader doesn't go, even the changes are saved and we have to refresh the page to check for updates.
Screen.Recording.2025-11-13.at.3.55.12.PM.mov
After:
after.mp4.mov