Skip to content

fix: saving alert doesn't disappear even its saved#2646

Closed
Faraz32123 wants to merge 1 commit intomasterfrom
fix/saving_alert_is_not_disappearing
Closed

fix: saving alert doesn't disappear even its saved#2646
Faraz32123 wants to merge 1 commit intomasterfrom
fix/saving_alert_is_not_disappearing

Conversation

@Faraz32123
Copy link
Copy Markdown
Contributor

Saving alert doesn't disappear even if its saved and keep showing loading status.

Before:
This saving loader doesn't go, even the changes are saved and we have to refresh the page to check for updates.

Screen.Recording.2025-11-13.at.3.55.12.PM.mov

After:

after.mp4.mov

saving alert doesn't disappear even if its saved and keep showing loading status
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.82%. Comparing base (e10ab27) to head (fca319b).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2646   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files        1231     1231           
  Lines       27629    27629           
  Branches     6221     6239   +18     
=======================================
  Hits        26199    26199           
  Misses       1359     1359           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradenmacdonald
Copy link
Copy Markdown
Contributor

This PR is making the same fix as #2614 . Please see my comment there - we just need this to fix it:

-    isLoading: savePending,
+    isPending: savePending,

The problem is this file is not using TypeScript so nobody noticed that isLoading is not actually defined anymore after we upgraded React Query.

@Faraz32123
Copy link
Copy Markdown
Contributor Author

This PR is making the same fix as #2614 . Please see my comment there - we just need this to fix it:

-    isLoading: savePending,
+    isPending: savePending,

The problem is this file is not using TypeScript so nobody noticed that isLoading is not actually defined anymore after we upgraded React Query.

Ohk, perfect. In that case, I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants