Skip to content

fix: publish status of container on adding new children#2587

Merged
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:navin/fal-4270/container-publish-status-update
Nov 3, 2025
Merged

fix: publish status of container on adding new children#2587
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:navin/fal-4270/container-publish-status-update

Conversation

@navinkarkera
Copy link
Copy Markdown
Contributor

Description

Updates publish status of container when adding new child components to a unit or other containers.

Also updates migration library selection text as described in #2582

Useful information to include:

  • Which user roles will this change impact? "Course Author"

Supporting information

Testing instructions

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 31, 2025
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Oct 31, 2025

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.81%. Comparing base (36c9eba) to head (4492c63).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2587    +/-   ##
========================================
  Coverage   94.81%   94.81%            
========================================
  Files        1225     1225            
  Lines       27481    27482     +1     
  Branches     6187     6025   -162     
========================================
+ Hits        26056    26057     +1     
  Misses       1367     1367            
  Partials       58       58            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! @navinkarkera This PR is in Draft. Is it ready to be merged?

@navinkarkera navinkarkera marked this pull request as ready for review November 3, 2025 04:56
@navinkarkera navinkarkera force-pushed the navin/fal-4270/container-publish-status-update branch from 77e8d3b to 4492c63 Compare November 3, 2025 07:15
@navinkarkera
Copy link
Copy Markdown
Contributor Author

@ChrisChV Yes, it is ready.

@ChrisChV ChrisChV merged commit bd82c1d into openedx:master Nov 3, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Nov 3, 2025
navinkarkera added a commit to open-craft/frontend-app-authoring that referenced this pull request Nov 5, 2025
Updates publish status of container when adding new child components to a unit or other containers.

(cherry picked from commit bd82c1d)
ChrisChV pushed a commit that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants