Skip to content

feat: Deleted/Added level diff in sync modal [FC-0097]#2549

Merged
ChrisChV merged 5 commits intoopenedx:masterfrom
open-craft:chris/FAL-4263-new-delete-states-on-sync-modal
Oct 22, 2025
Merged

feat: Deleted/Added level diff in sync modal [FC-0097]#2549
ChrisChV merged 5 commits intoopenedx:masterfrom
open-craft:chris/FAL-4263-new-delete-states-on-sync-modal

Conversation

@ChrisChV
Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV commented Oct 20, 2025

Description

  • Adds the Deleted and the Added level diff in sync container modal.
  • Fix the icons in the sync container modal
  • Which user roles will this change impact? "Course Author".
image image

Supporting information

Testing instructions

Deleted/Added level diff

  • In a library create this structure Section>Subsection>Unit>Components.
  • Add the new created Section to a Course.
  • In the library delete the Subsection and create a new Subsection>Unit>Component structure in the Section.
  • Publish all the changes.
  • In the Course, click on the sync button of the Section.
  • Go to the deleted Subsection, verify the new Deleted diff state.
  • Go to the added Subsection, verify the new Added diff state.

UX/UI Issues

  • In a library create this structure Section>Subsection>Unit>Components.
  • Add the Section, Subsection and Unit separately in a Course.
  • Make an update in a Component. Publish the change.
  • On the course open each sync modal. Verify that the icon is the correct for each container.
  • Check the same in the Library Updates page of the Course.

Other information

Merge before Ulmo Cut

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 20, 2025
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Oct 20, 2025

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 20, 2025
@ChrisChV ChrisChV changed the title feat: Deleted/Added level diff in sync modal feat: Deleted/Added level diff in sync modal [FC-0097] Oct 20, 2025
@ChrisChV ChrisChV marked this pull request as draft October 20, 2025 19:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.73%. Comparing base (e80930e) to head (541001c).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
- Coverage   94.74%   94.73%   -0.01%     
==========================================
  Files        1206     1213       +7     
  Lines       27064    27222     +158     
  Branches     6079     6141      +62     
==========================================
+ Hits        25641    25790     +149     
- Misses       1352     1361       +9     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV ChrisChV marked this pull request as ready for review October 20, 2025 22:00
Copy link
Copy Markdown
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Nice work! 👍

  • I tested this: (Verified added and deleted child pages)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Comment thread src/container-comparison/CompareContainersWidget.tsx Outdated
Comment thread src/container-comparison/data/apiHooks.ts Outdated
@ChrisChV ChrisChV enabled auto-merge (squash) October 22, 2025 20:41
@ChrisChV ChrisChV merged commit 9f16041 into openedx:master Oct 22, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Oct 22, 2025
Faraz32123 pushed a commit to edx/frontend-app-authoring that referenced this pull request Oct 24, 2025
- Adds the Deleted and the Added level diff in sync container modal.
- Fix the icons in the sync container modal
Faraz32123 pushed a commit to edx/frontend-app-authoring that referenced this pull request Oct 24, 2025
- Adds the Deleted and the Added level diff in sync container modal.
- Fix the icons in the sync container modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants