feat: Deleted/Added level diff in sync modal [FC-0097]#2549
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
- Coverage 94.74% 94.73% -0.01%
==========================================
Files 1206 1213 +7
Lines 27064 27222 +158
Branches 6079 6141 +62
==========================================
+ Hits 25641 25790 +149
- Misses 1352 1361 +9
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
navinkarkera
left a comment
There was a problem hiding this comment.
@ChrisChV Nice work! 👍
- I tested this: (Verified added and deleted child pages)
- I read through the code
- I checked for accessibility issues
- Includes documentation
- Adds the Deleted and the Added level diff in sync container modal. - Fix the icons in the sync container modal
- Adds the Deleted and the Added level diff in sync container modal. - Fix the icons in the sync container modal
Description
Supporting information
Testing instructions
Deleted/Added level diff
UX/UI Issues
Other information
Merge before Ulmo Cut
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'