[feature] add backup view for libraries v2#2532
[feature] add backup view for libraries v2#2532diana-villalvazo-wgu merged 28 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5d2d2b7 to
e6ef987
Compare
e6ef987 to
70aefaa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2532 +/- ##
========================================
Coverage 94.74% 94.74%
========================================
Files 1206 1212 +6
Lines 27042 27188 +146
Branches 5922 6106 +184
========================================
+ Hits 25620 25760 +140
+ Misses 1364 1357 -7
- Partials 58 71 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bradenmacdonald
left a comment
There was a problem hiding this comment.
Code looks fine, though I have some suggestions for making the tests more consistent with the other new tests in our codebase. Most of this is optional feedback so don't feel you have to change every single thing I pointed out.
| const mockLibraryData: { data: any } = { data: {} }; | ||
|
|
||
| jest.mock('@src/library-authoring/data/apiHooks', () => ({ | ||
| useContentLibrary: () => (mockLibraryData), | ||
| })); |
There was a problem hiding this comment.
This may be fine but I'd usually recommend the more realistic mock data helpers that we have:
import { mockContentLibrary } from '../data/api.mocks';
mockContentLibrary.applyMock();There was a problem hiding this comment.
I did try this one, but somehow the mocks don't apply properly, so the libraryData it's always undefined... not sure why exactly becasue it works in other places that have the exact same scenario... so I'll leave it as is for now
There was a problem hiding this comment.
Right?, I can show you if you want, maybe it's just me after seing the tests for too long 🤷♂️
There was a problem hiding this comment.
It's fine for now :p
|
Closes #2552 |
* feat: add backup view for libraries v2 * chore: updated paths and cleanup * chore: cleanup text * chore: added test * chore: fix contracts after rebase * chore: more tests to improve coverage * chore: more test for coverage * chore: more test for coverage * chore: fixed lint issues * chore: update naming for a more semantic one * chore: changed fireEvent to userEvent * chore: improved queryKeys * chore: lint cleanup * chore: changed tests and time to 1min * chore: even more tests * chore: split hook for library menu items * chore: fixed typo on refactor * chore: improved test to use available mocks * chore: change from jest.mocks to spyon * chore: update test based on commets * chore: update test to get URL from a better place * chore: added extra getters for new endpoints * chore: update test to prevent issues with useContentLibrary * chore: added comments for clarity * chore: lint fix * chore: updated url handle to use full URL * chore: linting fixes
* feat: add backup view for libraries v2 * chore: updated paths and cleanup * chore: cleanup text * chore: added test * chore: fix contracts after rebase * chore: more tests to improve coverage * chore: more test for coverage * chore: more test for coverage * chore: fixed lint issues * chore: update naming for a more semantic one * chore: changed fireEvent to userEvent * chore: improved queryKeys * chore: lint cleanup * chore: changed tests and time to 1min * chore: even more tests * chore: split hook for library menu items * chore: fixed typo on refactor * chore: improved test to use available mocks * chore: change from jest.mocks to spyon * chore: update test based on commets * chore: update test to get URL from a better place * chore: added extra getters for new endpoints * chore: update test to prevent issues with useContentLibrary * chore: added comments for clarity * chore: lint fix * chore: updated url handle to use full URL * chore: linting fixes
Description
This PR adds a new view for the v2 libraries which will allow the user to export a backup of the library for later import.
Useful information to include:
Before new dropdown was added:

New dropdown on v2 libraries for tools:

Backup page:

Supporting information
Covers the first part of #2448
Implements the first part of the views this figma design
Testing instructions
Assuming you have a working authoring dev environment and you have the right version of the edx-platform (latest master which includes: openedx/openedx-platform#37419)
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'