Skip to content

Commit ec4cd64

Browse files
authored
fix: configure modal visibility tab background overflow (#2923)
1 parent 4db8fca commit ec4cd64

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

src/course-outline/CourseOutline.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -498,6 +498,11 @@ const CourseOutline = () => {
498498
isOpen={isConfigureModalOpen}
499499
onClose={handleConfigureModalClose}
500500
onConfigureSubmit={handleConfigureItemSubmit}
501+
/**
502+
* Only sections need overflow visible (for the Release date datepicker, fixed in #2901);
503+
* enabling it for subsection/unit modals causes the Visibility tab background to clip.
504+
*/
505+
isOverflowVisible={itemCategory === COURSE_BLOCK_NAMES.chapter.id}
501506
currentItemData={currentItemData}
502507
enableProctoredExams={enableProctoredExams}
503508
enableTimedExams={enableTimedExams}

src/generic/configure-modal/ConfigureModal.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ interface Props {
2828
currentItemData?: AccessManagedXBlockDataTypes,
2929
isXBlockComponent?: boolean,
3030
isSelfPaced?: boolean,
31+
isOverflowVisible?: boolean,
3132
}
3233

3334
const ConfigureModal = ({
@@ -39,6 +40,7 @@ const ConfigureModal = ({
3940
enableTimedExams = false,
4041
isXBlockComponent = false,
4142
isSelfPaced,
43+
isOverflowVisible = false,
4244
}: Props) => {
4345
const intl = useIntl();
4446

@@ -298,7 +300,7 @@ const ConfigureModal = ({
298300
onClose={onClose}
299301
hasCloseButton
300302
isFullscreenOnMobile
301-
isOverflowVisible
303+
isOverflowVisible={isOverflowVisible}
302304
>
303305
<div data-testid="configure-modal">
304306
<ModalDialog.Header className="configure-modal__header">

0 commit comments

Comments
 (0)