test: fix completely broken tests

Author: bradenmacdonald

src/schedule-and-details/license-section/license-commons-options/LicenseCommonsOptions.test.jsx

@@ -1,7 +1,4 @@
-import React from 'react';
-import {
-  render, fireEvent, act, waitFor,
-} from '@testing-library/react';
+import { render, fireEvent } from '@testing-library/react';
 import { IntlProvider } from '@edx/frontend-platform/i18n';
 
 import { LICENSE_COMMONS_OPTIONS } from '../constants';
@@ -47,12 +44,14 @@ describe('<LicenseCommonsOptions />', () => {
   it('should call onToggleCheckbox event onClick', async () => {
     const { getAllByRole } = render(<RootWrapper {...props} />);
     const checkboxList = getAllByRole('checkbox');
-    act(() => {
-      fireEvent.click(checkboxList[1]);
-    });
+    expect(props.onToggleCheckbox).not.toHaveBeenCalled();
+    fireEvent.click(checkboxList[1]);
     expect(props.onToggleCheckbox).toHaveBeenCalledWith(LICENSE_COMMONS_OPTIONS.nonCommercial);
-    await waitFor(() => {
-      expect(checkboxList[1].checked).toBeFalsy();
-    });
+    // Note: there is no point in asserting that the checkbox is now checked,
+    // because it is a controlled component that never changes unless the props change.
+    // This test should really be implemented in a higher level component/page.
+    // await waitFor(() => {
+    //   expect(checkboxList[1].checked).toBeFalsy();
+    // });
   });
 });

src/schedule-and-details/messages.js src/schedule-and-details/messages.tssrc/schedule-and-details/messages.js renamed to src/schedule-and-details/messages.ts

@@ -1,6 +1,5 @@
-import React from 'react';
 import {
-  render, fireEvent, act, waitFor,
+  render, fireEvent, screen, waitFor,
 } from '@testing-library/react';
 import { IntlProvider } from '@edx/frontend-platform/i18n';
 
@@ -34,20 +33,15 @@ describe('<GradeRequirements />', () => {
   it('should call onChange on input change', () => {
     const { getByDisplayValue } = render(<RootWrapper {...props} />);
     const input = getByDisplayValue(props.entranceExamMinimumScorePct);
-    act(() => {
-      fireEvent.change(input, { target: { valueAsNumber: '31' } });
-    });
+    fireEvent.change(input, { target: { valueAsNumber: '31' } });
     expect(props.onChange).toHaveBeenCalledWith('31', 'entranceExamMinimumScorePct');
   });
 
   it('should show feedback error', async () => {
-    const { getByDisplayValue, getByText } = render(<RootWrapper {...props} />);
-    const input = getByDisplayValue(props.entranceExamMinimumScorePct);
-    act(() => {
-      fireEvent.change(input, { target: { valueAsNumber: '123' } });
-    });
+    const errorMessage = scheduleMessage.errorMessage8.defaultMessage;
+    render(<RootWrapper {...props} entranceExamMinimumScorePct="123" errorEffort={errorMessage} />);
     await waitFor(() => {
-      expect(getByText(scheduleMessage.errorMessage8.defaultMessage)).toBeInTheDocument();
+      expect(screen.getByText(errorMessage)).toBeInTheDocument();
     });
   });
 });