Skip to content

Commit af204c7

Browse files
test: run only oxlint, not eslint (#2909)
1 parent 2e62093 commit af204c7

2 files changed

Lines changed: 3 additions & 13 deletions

File tree

.github/workflows/validate.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,6 @@ jobs:
2121
with:
2222
name: code-coverage-report
2323
path: coverage/*.*
24-
# We are trying out oxlint for a while. Please report if you ever see lint issues that eslint catches but oxlint
25-
# misses. We expect the opposite (oxlint should catch more issues).
26-
lint-preview:
27-
runs-on: ubuntu-latest
28-
29-
steps:
30-
- uses: actions/checkout@v6
31-
- uses: actions/setup-node@v6
32-
with:
33-
node-version-file: '.nvmrc'
34-
- run: npm install
35-
- run: npm run oxlint
3624
coverage:
3725
runs-on: ubuntu-latest
3826
needs: tests

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,9 @@ validate-no-uncommitted-package-lock-changes:
5151
validate:
5252
make validate-no-uncommitted-package-lock-changes
5353
npm run i18n_extract
54-
npm run lint -- --max-warnings 0
54+
# We are trying out oxlint. Now that it's been working well for a while with both oxlint and eslint, we have disabled
55+
# eslint, and after a few weeks we'll evaluate whether any problems are slipping through if only oxlint is used.
56+
npm run oxlint
5557
npm run types
5658
npm run test:ci
5759
npm run build

0 commit comments

Comments
 (0)