Apply suggestions from code review

Co-authored-by: Brian Smith <[email protected]>

Author: jesperhodge

src/taxonomy/tag-list/UsageCountDisplay.tsx

@@ -5,7 +5,7 @@ import type { Row } from '@tanstack/react-table';
 import type {
   TreeRowData,
 } from '@src/taxonomy/tree-table/types';
-import { TagListRowData } from './types';
+import type { TagListRowData } from './types';
 import { getTagListRowData } from './utils';
 
 const UsageCountDisplay = ({ row }: { row: Row<TreeRowData>; }) => {

src/taxonomy/tag-list/tagColumns.tsx

@@ -16,7 +16,7 @@ import type {
   TreeColumnDef,
   TreeRowData,
 } from '@src/taxonomy/tree-table/types';
-import { TagListRowData } from './types';
+import type { TagListRowData } from './types';
 import messages from './messages';
 import OptionalExpandLink from './OptionalExpandLink';
 import UsageCountDisplay from './UsageCountDisplay';

src/taxonomy/tag-list/types.ts

@@ -1,4 +1,4 @@
-import { TreeRowData } from '@src/taxonomy/tree-table/types';
+import type { TreeRowData } from '@src/taxonomy/tree-table/types';
 
 export interface TagListRowData extends TreeRowData {
   depth: number;

src/taxonomy/tree-table/SaveErrorAlert.tsx

@@ -15,16 +15,11 @@ interface SaveErrorAlertProps {
 }
 const SaveErrorAlert = ({ draftError, isError, isUpdateError }: SaveErrorAlertProps) => {
   const intl = useIntl();
-  const hasError = (isError || isUpdateError) && !!draftError;
+  const hasError: boolean = (isError || isUpdateError) && !!draftError;
   const [alertOpen, setAlertOpen] = React.useState(hasError);
 
   useEffect(() => {
-    if (hasError) {
-      setAlertOpen(true);
-    }
-    if (!hasError) {
-      setAlertOpen(false);
-    }
+    setAlertOpen(hasError);
   }, [hasError, isError, isUpdateError, draftError]);
 
   if (!alertOpen) { return null; }