fix(course-outline): handle back from subsection without section

Author: navinkarkera

src/course-outline/outline-sidebar/AddSidebar.test.tsx

@@ -451,6 +451,23 @@ describe('AddSidebar', () => {
     expect(clearSelection).not.toHaveBeenCalled();
   });
 
+  it('back from subsection without section clears selection', async () => {
+    const user = userEvent.setup();
+    const section = outlineChildren[0];
+    const subsection = section.childInfo.children[0];
+    selectedContainerState = {
+      currentId: subsection.id,
+      subsectionId: subsection.id,
+    };
+    renderComponent();
+
+    const back = await screen.findByRole('button', { name: 'Back' });
+    await user.click(back);
+
+    expect(clearSelection).toHaveBeenCalled();
+    expect(openContainerSidebar).not.toHaveBeenCalled();
+  });
+
   it('back from section clears selection', async () => {
     const user = userEvent.setup();
     const section = outlineChildren[0];

src/course-outline/outline-sidebar/AddSidebar.tsx

@@ -401,8 +401,12 @@ export const AddSidebar = () => {
     const subsectionIndex = section
       ?.childInfo.children.findIndex((subsection) => subsection.id === subsectionId) ?? -1;
 
-    if (currentId === subsectionId && sectionId) {
-      openContainerSidebar(sectionId, undefined, sectionId, sectionIndex >= 0 ? sectionIndex : undefined);
+    if (currentId === subsectionId) {
+      if (sectionId) {
+        openContainerSidebar(sectionId, undefined, sectionId, sectionIndex >= 0 ? sectionIndex : undefined);
+        return;
+      }
+      clearSelection();
       return;
     }
 

src/course-outline/outline-sidebar/OutlineAlignSidebar.test.tsx

@@ -157,6 +157,28 @@ describe('OutlineAlignSidebar', () => {
     });
   });
 
+  it('back button from subsection without section clears selection', async () => {
+    jest
+      .spyOn(OutlineSidebarContext, 'useOutlineSidebarContext')
+      .mockReturnValue({
+        selectedContainerState: {
+          currentId: 'subsection-1',
+          subsectionId: 'subsection-1',
+        },
+        clearSelection,
+        openContainerSidebar,
+      } as any);
+
+    render(<OutlineAlignSidebar />);
+
+    const backButton = await screen.findByRole('button', { name: /back/i });
+    backButton.click();
+
+    expect(clearSelection).toHaveBeenCalled();
+    expect(setCurrentSelection).toHaveBeenCalledWith(undefined);
+    expect(openContainerSidebar).not.toHaveBeenCalled();
+  });
+
   it('back button from section clears selection', async () => {
     jest
       .spyOn(OutlineSidebarContext, 'useOutlineSidebarContext')

src/course-outline/outline-sidebar/OutlineAlignSidebar.tsx

@@ -30,13 +30,18 @@ export const OutlineAlignSidebar = () => {
       return;
     }
 
-    if (currentId === subsectionId && sectionId) {
-      openContainerSidebar(sectionId, undefined, sectionId, sectionIndex >= 0 ? sectionIndex : undefined);
-      setCurrentSelection({
-        currentId: sectionId,
-        sectionId,
-        index: sectionIndex >= 0 ? sectionIndex : undefined,
-      });
+    if (currentId === subsectionId) {
+      if (sectionId) {
+        openContainerSidebar(sectionId, undefined, sectionId, sectionIndex >= 0 ? sectionIndex : undefined);
+        setCurrentSelection({
+          currentId: sectionId,
+          sectionId,
+          index: sectionIndex >= 0 ? sectionIndex : undefined,
+        });
+        return;
+      }
+      clearSelection();
+      setCurrentSelection(undefined);
       return;
     }