fix: lint and typing issues

Author: navinkarkera

src/CourseAuthoringContext.tsx

@@ -1,16 +1,16 @@
 import { getConfig } from '@edx/frontend-platform';
 import { createContext, useContext, useMemo } from 'react';
 import { getAuthenticatedUser } from '@edx/frontend-platform/auth';
-import { CourseDetailsData } from './data/api';
-import { useCourseDetails, useWaffleFlags } from './data/apiHooks';
-import { RequestStatus, RequestStatusType } from './data/constants';
 import { useCreateCourseBlock } from '@src/course-outline/data/apiHooks';
 import { getCourseItem } from '@src/course-outline/data/api';
 import { useDispatch, useSelector } from 'react-redux';
 import { addSection, addSubsection, updateSavingStatus } from '@src/course-outline/data/slice';
 import { addNewSectionQuery, addNewSubsectionQuery, addNewUnitQuery } from '@src/course-outline/data/thunk';
 import { useNavigate } from 'react-router';
 import { getOutlineIndexData } from '@src/course-outline/data/selectors';
+import { RequestStatus, RequestStatusType } from './data/constants';
+import { useCourseDetails, useWaffleFlags } from './data/apiHooks';
+import { CourseDetailsData } from './data/api';
 
 export type CourseAuthoringContextData = {
   /** The ID of the current course */
@@ -113,23 +113,21 @@ export const CourseAuthoringProvider = ({
   */
   const handleAddUnitFromLibrary = useCreateCourseBlock(openUnitPage);
 
-  const context = useMemo<CourseAuthoringContextData>(() => {
-    return {
-      courseId,
-      courseUsageKey,
-      courseDetails,
-      courseDetailStatus,
-      canChangeProviders,
-      handleNewSectionSubmit,
-      handleNewSubsectionSubmit,
-      handleNewUnitSubmit,
-      handleAddSectionFromLibrary,
-      handleAddSubsectionFromLibrary,
-      handleAddUnitFromLibrary,
-      getUnitUrl,
-      openUnitPage,
-    };
-  }, [
+  const context = useMemo<CourseAuthoringContextData>(() => ({
+    courseId,
+    courseUsageKey,
+    courseDetails,
+    courseDetailStatus,
+    canChangeProviders,
+    handleNewSectionSubmit,
+    handleNewSubsectionSubmit,
+    handleNewUnitSubmit,
+    handleAddSectionFromLibrary,
+    handleAddSubsectionFromLibrary,
+    handleAddUnitFromLibrary,
+    getUnitUrl,
+    openUnitPage,
+  }), [
     courseId,
     courseUsageKey,
     courseDetails,

src/CourseAuthoringPage.tsx

@@ -58,7 +58,7 @@ const CourseAuthoringPage = ({ children }: Props) => {
             title={courseTitle}
             contextId={courseId}
             containerProps={{
-              size: "fluid",
+              size: 'fluid',
             }}
           />
         )

src/authz/data/apiHooks.ts

@@ -32,6 +32,6 @@ export const useUserPermissions = (
   enabled: boolean = true,
 ) => useQuery<PermissionValidationAnswer, Error>({
   queryKey: adminConsoleQueryKeys.permissions(permissions),
-  queryFn: enabled ? () => validateUserPermissions(permissions): skipToken,
+  queryFn: enabled ? () => validateUserPermissions(permissions) : skipToken,
   retry: false,
 });

src/course-outline/drag-helper/CourseItemOverlay.tsx

@@ -1,11 +1,11 @@
 import { Col, Icon, Row } from '@openedx/paragon';
 import { ArrowRight, DragIndicator } from '@openedx/paragon/icons';
 import { ContainerType } from '@src/generic/key-utils';
-import { getItemStatusBorder } from '../utils';
+import { getItemStatusBorder, ItemBadgeStatusValue } from '../utils';
 
 interface ItemProps {
   displayName: string;
-  status: string;
+  status: ItemBadgeStatusValue;
 }
 
 interface CourseItemOverlayProps extends ItemProps {

src/course-outline/drag-helper/utils.test.ts

@@ -26,7 +26,7 @@ describe('possibleSubsectionMoves', () => {
     { actions: { draggable: true } },
     { actions: { draggable: true } },
     { actions: { draggable: true } },
-  ];
+  ] as unknown as XBlock[];
 
   const createMoveFunction = possibleSubsectionMoves(
     mockSections,
@@ -39,7 +39,7 @@ describe('possibleSubsectionMoves', () => {
     const mockNonDraggableSubsections = [
       { actions: { draggable: false } },
       { actions: { draggable: true } },
-    ];
+    ] as unknown as XBlock[];
 
     const createMove = possibleSubsectionMoves(
       mockSections,

src/course-outline/header-navigations/HeaderActions.tsx

@@ -81,16 +81,16 @@ const HeaderActions = ({
         <Dropdown.Menu className="mt-1">
           {Object.entries(sidebarPages).filter(([, page]) => !page.hideFromActionMenu)
             .map(([key, page]: [OutlineSidebarPageKeys, SidebarPage]) => (
-            <Dropdown.Item
-              key={key}
-              onClick={() => setCurrentPageKey(key)}
-            >
-              <Stack direction="horizontal" gap={2}>
-                <Icon src={page.icon} />
-                {page.title}
-              </Stack>
-            </Dropdown.Item>
-          ))}
+              <Dropdown.Item
+                key={key}
+                onClick={() => setCurrentPageKey(key)}
+              >
+                <Stack direction="horizontal" gap={2}>
+                  <Icon src={page.icon} />
+                  {page.title}
+                </Stack>
+              </Dropdown.Item>
+            ))}
         </Dropdown.Menu>
       </Dropdown>
 

src/course-outline/hooks.jsx

@@ -9,6 +9,7 @@ import { getSavingStatus as getGenericSavingStatus } from '@src/generic/data/sel
 import { RequestStatus } from '@src/data/constants';
 import { useUnlinkDownstream } from '@src/generic/unlink-modal';
 
+import { useCourseAuthoringContext } from '@src/CourseAuthoringContext';
 import { COURSE_BLOCK_NAMES } from './constants';
 import {
   setCurrentItem,
@@ -57,7 +58,6 @@ import {
   syncDiscussionsTopics,
 } from './data/thunk';
 import { containerComparisonQueryKeys } from '../container-comparison/data/apiHooks';
-import { useCourseAuthoringContext } from '@src/CourseAuthoringContext';
 
 const useCourseOutline = ({ courseId }) => {
   const dispatch = useDispatch();

src/course-outline/outline-sidebar/AddSidebar.tsx

@@ -3,13 +3,12 @@ import { SchoolOutline } from '@openedx/paragon/icons';
 
 import { SidebarContent, SidebarSection, SidebarTitle } from '@src/generic/sidebar';
 
-import messages from './messages';
 import contentMessages from '@src/library-authoring/add-content/messages';
 import { useCourseAuthoringContext } from '@src/CourseAuthoringContext';
-import { ComponentPicker } from '../../library-authoring';
-import { ContentType } from '../../library-authoring/routes';
 import { SidebarFilters } from '@src/library-authoring/library-filters/SidebarFilters';
-import { Button, Stack, Tab, Tabs } from '@openedx/paragon';
+import {
+  Button, Stack, Tab, Tabs,
+} from '@openedx/paragon';
 import { getItemIcon } from '@src/generic/block-type-utils';
 import { useSelector } from 'react-redux';
 import { getSectionsList } from '@src/course-outline/data/selectors';
@@ -18,6 +17,9 @@ import { ComponentSelectedEvent } from '@src/library-authoring/common/context/Co
 import { COMPONENT_TYPES } from '@src/generic/block-type-utils/constants';
 import { ContainerType } from '@src/generic/key-utils';
 import { XBlock } from '@src/data/types';
+import { ContentType } from '../../library-authoring/routes';
+import { ComponentPicker } from '../../library-authoring';
+import messages from './messages';
 
 type ContainerTypes = 'unit' | 'subsection' | 'section';
 
@@ -37,7 +39,7 @@ const getLastEditableParent = (blockList: Array<XBlock>) => {
     index++;
   }
   return undefined;
-}
+};
 
 /** Add Content Button */
 const AddContentButton = ({ name, blockType } : AddContentButtonProps) => {
@@ -68,7 +70,7 @@ const AddContentButton = ({ name, blockType } : AddContentButtonProps) => {
       default:
         // istanbul ignore next: unreachable
         throw new Error(`Unrecognized block type ${blockType}`);
-    };
+    }
   }, [
     blockType,
     handleNewSectionSubmit,
@@ -84,7 +86,7 @@ const AddContentButton = ({ name, blockType } : AddContentButtonProps) => {
       className="m-2"
       iconBefore={getItemIcon(blockType)}
       onClick={onCreateContent}
-      disabled={(!lastSection && blockType==='subsection') || (!lastSubsection && blockType==='unit')}
+      disabled={(!lastSection && blockType === 'subsection') || (!lastSubsection && blockType === 'unit')}
     >
       {name}
     </Button>
@@ -99,21 +101,21 @@ const AddNewContent = () => {
       <AddContentButton
         key="section"
         name={intl.formatMessage(contentMessages.sectionButton)}
-        blockType='section'
+        blockType="section"
       />
       <AddContentButton
         key="subsection"
         name={intl.formatMessage(contentMessages.subsectionButton)}
-        blockType='subsection'
+        blockType="subsection"
       />
       <AddContentButton
         key="unit"
         name={intl.formatMessage(contentMessages.unitButton)}
-        blockType='unit'
+        blockType="unit"
       />
     </Stack>
   );
-}
+};
 
 /** Add Existing Content Tab Section */
 const ShowLibraryContent = () => {
@@ -160,7 +162,7 @@ const ShowLibraryContent = () => {
       default:
         // istanbul ignore next: unreachable
         throw new Error(`Unrecognized block type ${blockType}`);
-    };
+    }
   }, [
     courseUsageKey,
     handleAddSectionFromLibrary,
@@ -171,9 +173,9 @@ const ShowLibraryContent = () => {
   ]);
 
   const allowedBlocks = useMemo(() => {
-    let blocks: ContainerTypes[] = ['section'];
-    if (lastSection) blocks.push('subsection');
-    if (lastSubsection) blocks.push('unit');
+    const blocks: ContainerTypes[] = ['section'];
+    if (lastSection) { blocks.push('subsection'); }
+    if (lastSubsection) { blocks.push('unit'); }
     return blocks;
   }, [lastSection, lastSubsection, sectionsList]);
 
@@ -188,7 +190,7 @@ const ShowLibraryContent = () => {
       onComponentSelected={onComponentSelected}
     />
   );
-}
+};
 
 /** Tabs Component */
 const AddTabs = () => {
@@ -209,7 +211,7 @@ const AddTabs = () => {
       </Tab>
     </Tabs>
   );
-}
+};
 
 /** Main Sidebar Component */
 export const AddSidebar = () => {

src/course-outline/outline-sidebar/messages.ts

@@ -104,7 +104,7 @@ const messages = defineMessages({
     id: 'course-authoring.course-outline.sidebar.sidebar-section-add.add-existing-tab',
     defaultMessage: 'Add Existing',
     description: 'Tab title for adding existing library components in outline using sidebar',
-  }
+  },
 });
 
 export default messages;

src/course-outline/section-card/SectionCard.test.tsx

@@ -16,6 +16,14 @@ jest.mock('@src/course-unit/data/apiHooks', () => ({
   }),
 }));
 
+jest.mock('@src/CourseAuthoringContext', () => ({
+  useCourseAuthoringContext: () => ({
+    courseId: 5,
+    handleAddSubsectionFromLibrary: jest.fn(),
+    handleNewSubsectionSubmit: jest.fn(),
+  }),
+}));
+
 const unit = {
   id: 'block-v1:UNIX+UX1+2025_T3+type@unit+block@0',
 };
@@ -95,10 +103,8 @@ const renderComponent = (props?: object, entry = '/course/:courseId') => render(
     onEditSectionSubmit={onEditSectionSubmit}
     onDuplicateSubmit={jest.fn()}
     isSectionsExpanded
-    onNewSubsectionSubmit={jest.fn()}
     isSelfPaced={false}
     isCustomRelativeDatesActive={false}
-    onAddSubsectionFromLibrary={jest.fn()}
     resetScrollState={jest.fn()}
     {...props}
   >