chore: fix various lint/type issues found by oxlint (#2850)

Author: bradenmacdonald

plugins/course-apps/live/Settings.jsx

@@ -1,3 +1,4 @@
+// oxlint-disable unicorn/no-thenable
 import React, { useEffect } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 import { camelCase } from 'lodash';

plugins/course-apps/proctoring/Settings.test.jsx

@@ -28,6 +28,10 @@ const renderComponent = children => (
 let axiosMock;
 
 describe('ProctoredExamSettings', () => {
+  /**
+   * @param {boolean} isAdmin
+   * @param {string | undefined} org
+   */
   function setupApp(isAdmin = true, org = undefined) {
     mergeConfig({
       EXAMS_BASE_URL: 'http://exams.testing.co',

plugins/course-apps/teams/Settings.jsx

@@ -107,6 +107,7 @@ const TeamSettings = ({
         )
           .when('enabled', {
             is: true,
+            // oxlint-disable-next-line unicorn/no-thenable
             then: Yup.array().min(1),
           })
           .default([])

src/advanced-settings/data/thunks.js

@@ -25,7 +25,7 @@ export function fetchCourseAppSettings(courseId) {
         sortedDisplayName.push(displayName);
       });
       const sortedSettingValues = {};
-      sortedDisplayName.sort().forEach((displayName => {
+      sortedDisplayName.sort((a, b) => a.localeCompare(b)).forEach((displayName => {
         Object.entries(settingValues).forEach(([key, value]) => {
           if (value.displayName === displayName) {
             sortedSettingValues[key] = value;

src/certificates/certificate-section/CertificateSection.jsx

@@ -7,7 +7,7 @@ const CertificateSection = ({
   <section {...rest}>
     <Stack className="justify-content-between mb-2.5" direction="horizontal">
       <h2 className="lead section-title mb-0">{title}</h2>
-      {actions && actions}
+      {actions}
     </Stack>
     <hr className="mt-0 mb-4" />
     <div>

src/container-comparison/ContainerRow.tsx

@@ -9,14 +9,14 @@ import {
 import { FormattedMessage } from '@edx/frontend-platform/i18n';
 import { getItemIcon } from '@src/generic/block-type-utils';
 import { ContainerType } from '@src/generic/key-utils';
-import { COMPONENT_TYPES } from '@src/generic/block-type-utils/constants';
 import messages from './messages';
 import { ContainerState } from './types';
 import { isRowClickable } from './utils';
 
 export interface ContainerRowProps {
   title: string;
-  containerType: ContainerType | keyof typeof COMPONENT_TYPES | string;
+  /** containerType: can be one of `ContainerType` | `COMPONENT_TYPES` or any other string (3rd party XBlocks)  */
+  containerType: ContainerType | string;
   state?: ContainerState;
   side: 'Before' | 'After';
   originalName?: string;

src/container-comparison/utils.ts

@@ -128,6 +128,7 @@ export function diffPreviewContainerChildren<A extends CourseContainerChildBase,
 
   // Use new mapB for getting new index for added elements
   addedA.forEach((addedRow) => {
+    // oxlint-disable-next-line typescript/no-non-null-asserted-optional-chain FIXME: clean this up.
     updatedA.splice(mapB.get(addedRow.id)?.index!, 0, { ...addedRow, state: 'added' });
   });
 

src/content-tags-drawer/TagsTree.tsx

@@ -75,11 +75,17 @@ const TagComponent = ({
 };
 
 interface TagsTreeProps {
+  /** Array of taxonomy tags that are applied to the content. */
   tags: TagTree;
+  /** Key of the parent tag. */
   parentKey?: string;
+  /** Depth of the parent tag (root), used to render tabs for the tree. */
   rootDepth?: number;
+  /** Lineage of the tag. */
   lineage?: string[];
+  /** Function that is called when removing tags from the tree. */
   removeTagHandler?: (value: string) => void;
+  /** Optional component to render after the tags components. */
   afterTagsComponent?: React.ReactNode;
 }
 
@@ -121,17 +127,12 @@ interface TagsTreeProps {
  *
  */
 const TagsTree = ({
-  /** Array of taxonomy tags that are applied to the content. */
   tags,
-  /** Depth of the parent tag (root), used to render tabs for the tree. */
   rootDepth = 0,
-  /** Key of the parent tag. */
   parentKey,
-  /** Lineage of the tag. */
   lineage = [],
-  /** Function that is called when removing tags from the tree. */
   removeTagHandler,
-  /** Optional component to render after the tags components. */
+  // oxlint-disable-next-line oxc/only-used-in-recursion
   afterTagsComponent,
 }: TagsTreeProps) => {
   const { isEditMode } = useContext(ContentTagsDrawerContext);

src/course-outline/data/types.ts

@@ -10,14 +10,13 @@ export interface CourseStructure {
   hasChanges: boolean,
 }
 
-// TODO: Create interface for all `Object` fields in courseOutline
 export interface CourseOutline {
   courseReleaseDate: string;
   courseStructure: CourseStructure;
-  deprecatedBlocksInfo: Object;
+  deprecatedBlocksInfo: Record<string, any>; // TODO: Create interface for this type
   discussionsIncontextLearnmoreUrl: string;
-  initialState: Object;
-  initialUserClipboard: Object;
+  initialState: Record<string, any>; // TODO: Create interface for this type
+  initialUserClipboard: Record<string, any>; // TODO: Create interface for this type
   languageCode: string;
   lmsLink: string;
   mfeProctoredExamSettingsUrl: string;

src/course-outline/outline-sidebar/AddSidebar.test.tsx

@@ -70,9 +70,7 @@ const searchResult = {
   results: [
     {
       ...mockResult.results[0],
-      hits: [
-        ...mockResult.results[0].hits.slice(16, 19),
-      ],
+      hits: mockResult.results[0].hits.slice(16, 19),
     },
     {
       ...mockResult.results[1],