refactor: container children types

Author: navinkarkera

src/library-authoring/containers/ContainerRemover.test.tsx

@@ -59,11 +59,6 @@ describe('<ContainerRemover />', () => {
     ({ axiosMock } = initializeMocks());
   });
 
-  afterEach(() => {
-    jest.clearAllMocks();
-    axiosMock.restore();
-  });
-
   it('triggers update container children api call when duplicates are present', async () => {
     const user = userEvent.setup();
     const url = getLibraryContainerChildrenApiUrl(mockGetContainerChildren.unitIdWithDuplicate);

src/library-authoring/data/api.ts

@@ -702,10 +702,10 @@ export async function restoreContainer(containerId: string) {
 /**
  * Fetch a library container's children's metadata.
  */
-export async function getLibraryContainerChildren<T>(
+export async function getLibraryContainerChildren<ChildType = LibraryBlockMetadata | Container>(
   containerId: string,
   published: boolean = false,
-): Promise<T[]> {
+): Promise<ChildType[]> {
   const { data } = await getAuthenticatedHttpClient().get(
     getLibraryContainerChildrenApiUrl(containerId, published),
   );

src/library-authoring/data/apiHooks.ts

@@ -736,15 +736,18 @@ export const useRestoreContainer = (containerId: string) => {
 /**
  * Get the metadata and children for a container in a library
  */
-export const useContainerChildren = <T extends { id: string, isNew?: boolean }>(
-  containerId?: string,
-  published: boolean = false,
-) => (
+export const useContainerChildren = <ChildType extends {
+  id: string;
+  isNew?: boolean;
+} = api.LibraryBlockMetadata | api.Container>(
+    containerId?: string,
+    published: boolean = false,
+  ) => (
     useQuery({
       enabled: !!containerId,
       queryKey: libraryAuthoringQueryKeys.containerChildren(containerId!),
-      queryFn: () => api.getLibraryContainerChildren<T>(containerId!, published),
-      structuralSharing: (oldData: T[], newData: T[]) => {
+      queryFn: () => api.getLibraryContainerChildren<ChildType>(containerId!, published),
+      structuralSharing: (oldData: ChildType[], newData: ChildType[]) => {
       // This just sets `isNew` flag to new children components
         if (oldData) {
           const oldDataIds = oldData.map((obj) => obj.id);