feat(pages-and-resources): remove isEditable prop and clean up related components

Author: bra-i-am

src/pages-and-resources/discussions/app-config-form/AppConfigFormSaveButton.jsx

@@ -9,13 +9,11 @@ import messages from './messages';
 import { SAVING } from '../data/slice';
 import { AppConfigFormContext } from './AppConfigFormProvider';
 import { useModel } from '../../../generic/model-store';
-import { PagesAndResourcesContext } from '../../PagesAndResourcesProvider';
 
 const AppConfigFormSaveButton = ({ labelText }) => {
   const intl = useIntl();
   const saveStatus = useSelector(state => state.discussions.saveStatus);
   const { selectedAppId } = useSelector((state) => state.discussions);
-  const { isEditable } = useContext(PagesAndResourcesContext);
 
   const app = useModel('apps', selectedAppId);
   const canSubmit = getAuthenticatedUser().administrator || !app?.adminOnlyConfig;
@@ -47,7 +45,6 @@ const AppConfigFormSaveButton = ({ labelText }) => {
         }}
         state={submitButtonState}
         onClick={handleSave}
-        disabled={!isEditable}
         style={{ minWidth: '88px' }}
       />
     )

src/pages-and-resources/discussions/app-config-form/apps/lti/LtiConfigForm.jsx

@@ -113,7 +113,6 @@ const LtiConfigForm = ({ onSubmit, formRef }) => {
                 onChange={handleChange}
                 onBlur={handleBlur}
                 value={values.consumerKey}
-
               />
               {isInvalidConsumerKey && (
                 <Form.Control.Feedback type="invalid" hasIcon={false}>
@@ -145,7 +144,6 @@ const LtiConfigForm = ({ onSubmit, formRef }) => {
                 onChange={handleChange}
                 onBlur={handleBlur}
                 value={values.launchUrl}
-
               />
               {isInvalidLaunchUrl && (
                 <Form.Control.Feedback type="invalid" hasIcon={false}>
@@ -166,7 +164,6 @@ const LtiConfigForm = ({ onSubmit, formRef }) => {
                 onBlur={handleBlur}
                 checked={values.piiShareUsername}
                 label={intl.formatMessage(messages.piiShareUsername)}
-
               />
               <Form.Check
                 type="checkbox"
@@ -175,7 +172,6 @@ const LtiConfigForm = ({ onSubmit, formRef }) => {
                 onBlur={handleBlur}
                 checked={values.piiShareEmail}
                 label={intl.formatMessage(messages.piiShareEmail)}
-
               />
             </Form.Group>
           </div>

src/pages-and-resources/discussions/app-config-form/apps/openedx/OpenedXConfigForm.jsx

@@ -141,11 +141,7 @@ const OpenedXConfigForm = ({
                 {!legacy
                   && (
                     <>
-                      <InContextDiscussionFields
-                        onBlur={handleBlur}
-                        onChange={handleChange}
-                        values={values}
-                      />
+                      <InContextDiscussionFields onBlur={handleBlur} onChange={handleChange} values={values} />
                       <AppConfigFormDivider thick />
                     </>
                   )}