Skip to content

Commit 421bd7b

Browse files
committed
fix: lint issues
1 parent 72edea9 commit 421bd7b

3 files changed

Lines changed: 26 additions & 6 deletions

File tree

src/course-outline/data/api.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,13 +267,20 @@ export async function configureCourseSubsection(
267267
} = variables;
268268

269269
const metadata = pickDefined({
270-
visible_to_staff_only: isVisibleToStaffOnly === undefined ? undefined : isVisibleToStaffOnly ? true : null,
270+
visible_to_staff_only: (() => {
271+
if (isVisibleToStaffOnly === undefined) {
272+
return undefined;
273+
}
274+
return isVisibleToStaffOnly ? true : null;
275+
})(),
271276
due: dueDate,
272277
hide_after_due: hideAfterDue,
273278
show_correctness: showCorrectness,
274279
is_practice_exam: isPracticeExam,
275280
is_time_limited: isTimeLimited,
276-
is_proctored_enabled: (isProctoredExam !== undefined || isPracticeExam !== undefined || isOnboardingExam !== undefined)
281+
is_proctored_enabled: (
282+
isProctoredExam !== undefined || isPracticeExam !== undefined || isOnboardingExam !== undefined
283+
)
277284
? (isProctoredExam || isPracticeExam || isOnboardingExam)
278285
: undefined,
279286
exam_review_rules: examReviewRules,

src/course-outline/outline-sidebar/info-sidebar/SubsectionSettings.test.tsx

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,9 @@ describe('SubsectionSettings', () => {
130130
it('handles grading select and due date/time changes', async () => {
131131
apiHooks.useCourseDetails.mockReturnValue({ data: { selfPaced: false } });
132132
apiHooks.useCourseItemData.mockReturnValue({
133-
data: { ...baseItemData, graded: false, prereqMinScore: '50', prereqMinCompletion: '75' },
133+
data: {
134+
...baseItemData, graded: false, prereqMinScore: '50', prereqMinCompletion: '75',
135+
},
134136
isPending: false,
135137
});
136138

@@ -178,7 +180,14 @@ describe('SubsectionSettings', () => {
178180

179181
it('does not call mutate when item data is pending', async () => {
180182
apiHooks.useCourseDetails.mockReturnValue({ data: { selfPaced: false } });
181-
apiHooks.useCourseItemData.mockReturnValue({ data: { ...baseItemData, start: null, graded: false }, isPending: true });
183+
apiHooks.useCourseItemData.mockReturnValue({
184+
data: {
185+
...baseItemData,
186+
start: null,
187+
graded: false,
188+
},
189+
isPending: true,
190+
});
182191

183192
const user = userEvent.setup();
184193
render(<SubsectionSettings subsectionId={subsectionId} />);
@@ -189,7 +198,9 @@ describe('SubsectionSettings', () => {
189198

190199
it('resets grading local state when itemData changes', async () => {
191200
apiHooks.useCourseDetails.mockReturnValue({ data: { selfPaced: false } });
192-
const firstItemData = { ...baseItemData, format: 'g1', due: '2024-01-01', graded: true };
201+
const firstItemData = {
202+
...baseItemData, format: 'g1', due: '2024-01-01', graded: true,
203+
};
193204
const secondItemData = { ...firstItemData, format: 'g2', due: '2024-02-02' };
194205

195206
apiHooks.useCourseItemData.mockReturnValue({ data: firstItemData, isPending: false });

src/course-outline/outline-sidebar/info-sidebar/SubsectionSettings.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ import AdvancedTab from '@src/generic/configure-modal/AdvancedTab';
1111
import { DatepickerControl, DATEPICKER_TYPES } from '@src/generic/datepicker-control';
1212
import { SidebarContent, SidebarSection } from '@src/generic/sidebar';
1313
import { useStateWithCallback } from '@src/hooks';
14-
import { useCallback, useEffect, useRef, useState } from 'react';
14+
import {
15+
useCallback, useEffect, useRef, useState,
16+
} from 'react';
1517
import { useSelector } from 'react-redux';
1618
import { ReleaseSection } from './sharedSettings/ReleaseSection';
1719
import messages from './messages';

0 commit comments

Comments
 (0)