Skip to content

Commit 3db2ce7

Browse files
committed
fix: solve test issues
1 parent 90aee6a commit 3db2ce7

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

src/grading-settings/GradingSettings.test.jsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -143,17 +143,14 @@ describe('<GradingSettings />', () => {
143143
});
144144

145145
describe('<GradingSettings /> permissions', () => {
146-
const setupMocks = () => {
146+
beforeEach(() => {
147+
jest.restoreAllMocks();
147148
const mocks = initializeMocks();
148149
Object.defineProperty(window, 'scrollTo', { value: jest.fn(), writable: true });
149150
const { axiosMock: mock } = mocks;
150151
mock.onGet(getGradingSettingsApiUrl(courseId)).reply(200, gradingSettings);
151152
mock.onPost(getGradingSettingsApiUrl(courseId)).reply(200, {});
152153
mock.onGet(getCourseSettingsApiUrl(courseId)).reply(200, {});
153-
return mock;
154-
};
155-
156-
beforeEach(() => {
157154
jest.mocked(useUserPermissionsWithAuthzCourse).mockReturnValue({
158155
isLoading: false,
159156
permissions: { canViewGradingSettings: true, canEditGradingSettings: true },
@@ -162,14 +159,12 @@ describe('<GradingSettings /> permissions', () => {
162159

163160
it('should render normally when authz flag is disabled (no regression)', async () => {
164161
mockWaffleFlags({ enableAuthzCourseAuthoring: false });
165-
setupMocks();
166162
render(<RootWrapper />);
167163
expect(await screen.findAllByText(messages.headingTitle.defaultMessage)).not.toHaveLength(0);
168164
});
169165

170166
it('should render normally when user has view and edit permissions', async () => {
171167
mockWaffleFlags({ enableAuthzCourseAuthoring: true });
172-
setupMocks();
173168
render(<RootWrapper />);
174169
expect(await screen.findAllByText(messages.headingTitle.defaultMessage)).not.toHaveLength(0);
175170
});
@@ -180,7 +175,6 @@ describe('<GradingSettings /> permissions', () => {
180175
isLoading: false,
181176
permissions: { canViewGradingSettings: false, canEditGradingSettings: false },
182177
});
183-
setupMocks();
184178
render(<RootWrapper />);
185179
expect(await screen.findByTestId('permissionDeniedAlert')).toBeInTheDocument();
186180
});
@@ -191,7 +185,6 @@ describe('<GradingSettings /> permissions', () => {
191185
isLoading: false,
192186
permissions: { canViewGradingSettings: true, canEditGradingSettings: false },
193187
});
194-
setupMocks();
195188
render(<RootWrapper />);
196189
const segmentInputs = await screen.findAllByTestId('grading-scale-segment-input');
197190
segmentInputs.forEach((input) => expect(input).toBeDisabled());
@@ -203,7 +196,6 @@ describe('<GradingSettings /> permissions', () => {
203196
isLoading: false,
204197
permissions: { canViewGradingSettings: true, canEditGradingSettings: false },
205198
});
206-
setupMocks();
207199
render(<RootWrapper />);
208200
const segmentInputs = await screen.findAllByTestId('grading-scale-segment-input');
209201
// Trigger a change to show the save alert

0 commit comments

Comments
 (0)