test: improve coverage

Author: navinkarkera

src/library-authoring/import-course/stepper/ImportStepperPage.test.tsx

@@ -12,7 +12,9 @@ import studioHomeMock from '@src/studio-home/__mocks__/studioHomeMock';
 import { getCourseDetailsApiUrl } from '@src/course-outline/data/api';
 import { LibraryProvider } from '@src/library-authoring/common/context/LibraryContext';
 import { mockContentLibrary, mockGetMigrationInfo } from '@src/library-authoring/data/api.mocks';
+import { useGetBlockTypes } from '@src/search-manager';
 import { ImportStepperPage } from './ImportStepperPage';
+import { bulkMigrateContentToLibrariesUrl } from '../../../data/api';
 
 let axiosMock;
 mockGetMigrationInfo.applyMock();
@@ -29,6 +31,11 @@ jest.mock('react-router-dom', () => ({
   useNavigate: () => mockNavigate,
 }));
 
+// Mock the useGetBlockTypes hook
+jest.mock('@src/search-manager', () => ({
+  useGetBlockTypes: jest.fn().mockReturnValue({ isPending: true, data: null }),
+}));
+
 const renderComponent = (studioHomeState: Partial<StudioHomeState> = {}) => {
   // Generate a custom initial state based on studioHomeCoursesRequestParams
   const customInitialState: Partial<DeprecatedReduxState> = {
@@ -151,4 +158,52 @@ describe('<ImportStepperModal />', () => {
     expect(screen.getByText(/managing risk in the information age/i)).toBeInTheDocument();
     expect(courseCard).toBeChecked();
   });
+
+  it('should import select course on button click', async () => {
+    (useGetBlockTypes as jest.Mock).mockReturnValue({
+      isPending: false,
+      data: {
+        chapter: 1,
+        sequential: 2,
+        vertical: 3,
+        html: 5,
+        problem: 3,
+      },
+    });
+    const user = userEvent.setup();
+    renderComponent();
+    axiosMock.onPost(bulkMigrateContentToLibrariesUrl()).reply(200);
+    axiosMock.onGet(getCourseDetailsApiUrl('course-v1:HarvardX+123+2023')).reply(200, {
+      courseId: 'course-v1:HarvardX+123+2023',
+      title: 'Managing Risk in the Information Age',
+      subtitle: '',
+      org: 'HarvardX',
+      description: 'This is a test course',
+    });
+
+    const nextButton = await screen.findByRole('button', { name: /next step/i });
+    expect(nextButton).toBeDisabled();
+
+    // Select a course
+    const courseCard = screen.getAllByRole('radio')[0];
+    await user.click(courseCard);
+    expect(courseCard).toBeChecked();
+
+    // Click next
+    expect(nextButton).toBeEnabled();
+    await user.click(nextButton);
+
+    expect(await screen.findByText('Analysis Summary')).toBeInTheDocument();
+    // Analysis completed
+    expect(await screen.findByText('Import Analysis Completed: Reimport')).toBeInTheDocument();
+    const importBtn = await screen.findByRole('button', { name: 'Import Course' });
+    await user.click(importBtn);
+
+    await waitFor(() => {
+      expect(axiosMock.history.post.length).toBe(1);
+    });
+    expect(axiosMock.history.post[0].data).toBe(
+      '{"sources":["course-v1:HarvardX+123+2023"],"target":"lib:Axim:TEST","create_collections":true,"repeat_handling_strategy":"fork","composition_level":"section"}',
+    );
+  });
 });

src/library-authoring/import-course/stepper/ImportStepperPage.tsx

@@ -71,6 +71,7 @@ export const ImportStepperPage = () => {
   const navigate = useNavigate();
   const [currentStep, setCurrentStep] = useState<MigrationStep>('select-course');
   const [selectedCourseId, setSelectedCourseId] = useState<string>();
+  const [analysisCompleted, setAnalysisCompleted] = useState<boolean>(false);
   const { data: courseData } = useCourseDetails(selectedCourseId);
   const { libraryId, libraryData, readOnly } = useLibraryContext();
   const { showToast } = useContext(ToastContext);
@@ -151,7 +152,10 @@ export const ImportStepperPage = () => {
                   eventKey="review-details"
                   title={intl.formatMessage(messages.importCourseReviewDetailsStep)}
                 >
-                  <ReviewImportDetails courseId={selectedCourseId} />
+                  <ReviewImportDetails
+                    markAnalysisComplete={setAnalysisCompleted}
+                    courseId={selectedCourseId}
+                  />
                 </Stepper.Step>
               </Stepper>
               <div className="mt-4">
@@ -176,6 +180,7 @@ export const ImportStepperPage = () => {
                       onClick={handleImportCourse}
                       label={intl.formatMessage(messages.importCourseButton)}
                       variant="primary"
+                      disabled={!analysisCompleted}
                     />
                   </ActionRow>
                 )}

src/library-authoring/import-course/stepper/ReviewImportDetails.test.tsx

@@ -9,6 +9,7 @@ import messages from '../messages';
 
 mockContentLibrary.applyMock();
 const { libraryId } = mockContentLibrary;
+const markAnalysisComplete = jest.fn();
 
 // Mock the useCourseDetails hook
 jest.mock('@src/course-outline/data/apiHooks', () => ({
@@ -47,10 +48,11 @@ describe('ReviewImportDetails', () => {
   });
 
   it('renders loading spinner when isPending is true', async () => {
-    render(<ReviewImportDetails courseId="test-course-id" />);
+    render(<ReviewImportDetails markAnalysisComplete={markAnalysisComplete} courseId="test-course-id" />);
 
     const spinners = await screen.findAllByRole('status');
     spinners.every((spinner) => expect(spinner.textContent).toEqual('Loading...'));
+    expect(markAnalysisComplete).toHaveBeenCalledWith(false);
   });
 
   it('renders import progress status when isBlockDataPending or migrationInfoIsPending is true', async () => {
@@ -60,10 +62,11 @@ describe('ReviewImportDetails', () => {
       data: null,
     });
 
-    render(<ReviewImportDetails courseId="test-course-id" />);
+    render(<ReviewImportDetails markAnalysisComplete={markAnalysisComplete} courseId="test-course-id" />);
 
     expect(await screen.findByRole('alert')).toBeInTheDocument();
     expect(await screen.findByText(/Import Analysis in Progress/i)).toBeInTheDocument();
+    expect(markAnalysisComplete).toHaveBeenCalledWith(false);
   });
 
   it('renders warning when reimport', async () => {
@@ -82,7 +85,7 @@ describe('ReviewImportDetails', () => {
       data: { html: 1 },
     });
 
-    render(<ReviewImportDetails courseId="test-course-id" />);
+    render(<ReviewImportDetails markAnalysisComplete={markAnalysisComplete} courseId="test-course-id" />);
 
     expect(await screen.findByRole('alert')).toBeInTheDocument();
     expect(await screen.findByText(/Import Analysis Completed: Reimport/i)).toBeInTheDocument();
@@ -91,6 +94,7 @@ describe('ReviewImportDetails', () => {
         .replace('{courseName}', 'Test Course')
         .replace('{libraryName}', 'Library title'),
     )).toBeInTheDocument();
+    expect(markAnalysisComplete).toHaveBeenCalledWith(true);
   });
 
   it('renders warning when unsupportedBlockPercentage > 0', async () => {
@@ -110,7 +114,7 @@ describe('ReviewImportDetails', () => {
       },
     });
 
-    render(<ReviewImportDetails courseId="test-course-id" />);
+    render(<ReviewImportDetails markAnalysisComplete={markAnalysisComplete} courseId="test-course-id" />);
 
     expect(await screen.findByRole('alert')).toBeInTheDocument();
     expect(await screen.findByText(/Import Analysis Complete/i)).toBeInTheDocument();
@@ -127,6 +131,7 @@ describe('ReviewImportDetails', () => {
     expect(await screen.findByText('3')).toBeInTheDocument();
     expect(await screen.findByText('Components')).toBeInTheDocument();
     expect(await screen.findByText('1/2')).toBeInTheDocument();
+    expect(markAnalysisComplete).toHaveBeenCalledWith(true);
   });
 
   it('renders success alert when no unsupported blocks', async () => {
@@ -146,7 +151,7 @@ describe('ReviewImportDetails', () => {
       },
     });
 
-    render(<ReviewImportDetails courseId="test-course-id" />);
+    render(<ReviewImportDetails markAnalysisComplete={markAnalysisComplete} courseId="test-course-id" />);
 
     expect(await screen.findByRole('alert')).toBeInTheDocument();
     expect(await screen.findByText(
@@ -163,5 +168,6 @@ describe('ReviewImportDetails', () => {
     expect(await screen.findByText('3')).toBeInTheDocument();
     expect(await screen.findByText('Components')).toBeInTheDocument();
     expect(await screen.findByText('8')).toBeInTheDocument();
+    expect(markAnalysisComplete).toHaveBeenCalledWith(true);
   });
 });

src/library-authoring/import-course/stepper/ReviewImportDetails.tsx

@@ -4,7 +4,7 @@ import { Alert, Stack } from '@openedx/paragon';
 import { LoadingSpinner } from '@src/generic/Loading';
 import { useCourseDetails } from '@src/course-outline/data/apiHooks';
 
-import { useMemo } from 'react';
+import { useEffect, useMemo } from 'react';
 import { CheckCircle, Warning } from '@openedx/paragon/icons';
 import { useLibraryContext } from '@src/library-authoring/common/context/LibraryContext';
 import { useMigrationInfo } from '@src/library-authoring/data/apiHooks';
@@ -14,9 +14,11 @@ import messages from '../messages';
 
 interface Props {
   courseId?: string;
+  markAnalysisComplete: (analysisCompleted: boolean) => void;
 }
 
-interface BannerProps extends Props {
+interface BannerProps {
+  courseId?: string;
   isBlockDataPending?: boolean;
   unsupportedBlockPercentage: number;
 }
@@ -112,11 +114,15 @@ const Banner = ({ courseId, isBlockDataPending, unsupportedBlockPercentage }: Ba
   );
 };
 
-export const ReviewImportDetails = ({ courseId }: Props) => {
+export const ReviewImportDetails = ({ courseId, markAnalysisComplete }: Props) => {
   const { data: blockTypes, isPending: isBlockDataPending } = useGetBlockTypes([
     `context_key = "${courseId}"`,
   ]);
 
+  useEffect(() => {
+    markAnalysisComplete(!isBlockDataPending);
+  }, [isBlockDataPending]);
+
   const totalUnsupportedBlocks = useMemo(() => {
     if (!blockTypes) {
       return 0;