Skip to content

Commit 282bdad

Browse files
navinkarkeranavinkarkera
committed
fix: lint issues
1 parent 9b7742f commit 282bdad

4 files changed

Lines changed: 32 additions & 28 deletions

File tree

‎src/course-unit/CourseUnit.test.tsx‎

Lines changed: 27 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import {
3333
} from '@src/library-authoring/data/api.mocks';
3434

3535
import { mockContentSearchConfig } from '@src/search-manager/data/api.mock';
36+
import { getCourseItemApiUrl } from '@src/course-outline/data/api';
3637
import {
3738
getCourseSectionVerticalApiUrl,
3839
getCourseVerticalChildrenApiUrl,
@@ -75,7 +76,6 @@ import headerNavigationsMessages from './header-navigations/messages';
7576
import legacySidebarMessages from './legacy-sidebar/messages';
7677
import unitInfoMessages from './unit-sidebar/unit-info/messages';
7778
import messages from './messages';
78-
import { getCourseItemApiUrl } from '@src/course-outline/data/api';
7979

8080
let axiosMock;
8181
let store;
@@ -512,7 +512,9 @@ describe('<CourseUnit />', () => {
512512
);
513513

514514
// check if the sidebar status is Published and Live
515-
expect(await screen.findByText(legacySidebarMessages.sidebarTitlePublishedAndLive.defaultMessage)).toBeInTheDocument();
515+
expect(
516+
await screen.findByText(legacySidebarMessages.sidebarTitlePublishedAndLive.defaultMessage),
517+
).toBeInTheDocument();
516518
expect(await screen.findByText(
517519
unitInfoMessages.publishLastPublished.defaultMessage
518520
.replace('{publishedOn}', courseSectionVerticalMock.xblock_info.published_on)
@@ -564,7 +566,9 @@ describe('<CourseUnit />', () => {
564566
expect(await screen.findByText(unitInfoMessages.visibilityVisibleToTitle.defaultMessage)).toBeInTheDocument();
565567
expect(await screen.findByText(unitInfoMessages.visibilityCheckboxTitle.defaultMessage)).toBeInTheDocument();
566568
expect(await screen.findByText(legacySidebarMessages.actionButtonPublishTitle.defaultMessage)).toBeInTheDocument();
567-
expect(await screen.findByText(legacySidebarMessages.actionButtonDiscardChangesTitle.defaultMessage)).toBeInTheDocument();
569+
expect(
570+
await screen.findByText(legacySidebarMessages.actionButtonDiscardChangesTitle.defaultMessage),
571+
).toBeInTheDocument();
568572
expect(await screen.findByText(courseSectionVerticalMock.xblock_info.release_date)).toBeInTheDocument();
569573
expect(await screen.findByText(
570574
unitInfoMessages.publishInfoDraftSaved.defaultMessage
@@ -745,7 +749,9 @@ describe('<CourseUnit />', () => {
745749
expect(await screen.findByText(unitInfoMessages.visibilityVisibleToTitle.defaultMessage)).toBeInTheDocument();
746750
expect(await screen.findByText(unitInfoMessages.visibilityCheckboxTitle.defaultMessage)).toBeInTheDocument();
747751
expect(await screen.findByText(legacySidebarMessages.actionButtonPublishTitle.defaultMessage)).toBeInTheDocument();
748-
expect(await screen.findByText(legacySidebarMessages.actionButtonDiscardChangesTitle.defaultMessage)).toBeInTheDocument();
752+
expect(
753+
await screen.findByText(legacySidebarMessages.actionButtonDiscardChangesTitle.defaultMessage),
754+
).toBeInTheDocument();
749755
expect(await screen.findByText(courseSectionVerticalMock.xblock_info.release_date)).toBeInTheDocument();
750756
expect(await screen.findByText(
751757
unitInfoMessages.publishInfoDraftSaved.defaultMessage
@@ -937,7 +943,9 @@ describe('<CourseUnit />', () => {
937943
expect(await screen.findByText(unitInfoMessages.visibilityVisibleToTitle.defaultMessage)).toBeInTheDocument();
938944
expect(await screen.findByText(unitInfoMessages.visibilityCheckboxTitle.defaultMessage)).toBeInTheDocument();
939945
expect(await screen.findByText(legacySidebarMessages.actionButtonPublishTitle.defaultMessage)).toBeInTheDocument();
940-
expect(await screen.findByText(legacySidebarMessages.actionButtonDiscardChangesTitle.defaultMessage)).toBeInTheDocument();
946+
expect(
947+
await screen.findByText(legacySidebarMessages.actionButtonDiscardChangesTitle.defaultMessage),
948+
).toBeInTheDocument();
941949
expect(await screen.findByText(courseSectionVerticalMock.xblock_info.release_date)).toBeInTheDocument();
942950
expect(await screen.findByText(
943951
unitInfoMessages.publishInfoDraftSaved.defaultMessage
@@ -988,7 +996,9 @@ describe('<CourseUnit />', () => {
988996
await user.click(publishButton);
989997

990998
// check if the sidebar status is Published and Live
991-
expect(await screen.findByText(legacySidebarMessages.sidebarTitlePublishedAndLive.defaultMessage)).toBeInTheDocument();
999+
expect(
1000+
await screen.findByText(legacySidebarMessages.sidebarTitlePublishedAndLive.defaultMessage),
1001+
).toBeInTheDocument();
9921002
expect(await screen.findByText(
9931003
unitInfoMessages.publishLastPublished.defaultMessage
9941004
.replace('{publishedOn}', courseSectionVerticalMock.xblock_info.published_on)
@@ -1025,7 +1035,9 @@ describe('<CourseUnit />', () => {
10251035
expect(await screen.findByText(unitInfoMessages.visibilityVisibleToTitle.defaultMessage)).toBeInTheDocument();
10261036
expect(await screen.findByText(unitInfoMessages.visibilityCheckboxTitle.defaultMessage)).toBeInTheDocument();
10271037
expect(await screen.findByText(legacySidebarMessages.actionButtonPublishTitle.defaultMessage)).toBeInTheDocument();
1028-
expect(await screen.findByText(legacySidebarMessages.actionButtonDiscardChangesTitle.defaultMessage)).toBeInTheDocument();
1038+
expect(
1039+
await screen.findByText(legacySidebarMessages.actionButtonDiscardChangesTitle.defaultMessage),
1040+
).toBeInTheDocument();
10291041
expect(await screen.findByText(courseSectionVerticalMock.xblock_info.release_date)).toBeInTheDocument();
10301042
expect(await screen.findByText(
10311043
unitInfoMessages.publishInfoDraftSaved.defaultMessage
@@ -1116,17 +1128,13 @@ describe('<CourseUnit />', () => {
11161128
it('should toggle visibility from sidebar and update course unit state accordingly', async () => {
11171129
const user = userEvent.setup();
11181130
render(<RootWrapper />);
1119-
let courseUnitSidebar;
1120-
let draftUnpublishedChangesHeading;
1121-
let visibilityCheckbox;
1122-
1123-
courseUnitSidebar = await screen.findByTestId('course-unit-sidebar');
1131+
const courseUnitSidebar = await screen.findByTestId('course-unit-sidebar');
11241132

1125-
draftUnpublishedChangesHeading = await within(courseUnitSidebar)
1133+
const draftUnpublishedChangesHeading = await within(courseUnitSidebar)
11261134
.findByText(legacySidebarMessages.sidebarTitleDraftUnpublishedChanges.defaultMessage);
11271135
expect(draftUnpublishedChangesHeading).toBeInTheDocument();
11281136

1129-
visibilityCheckbox = await within(courseUnitSidebar)
1137+
const visibilityCheckbox = await within(courseUnitSidebar)
11301138
.findByLabelText(unitInfoMessages.visibilityCheckboxTitle.defaultMessage);
11311139
expect(visibilityCheckbox).not.toBeChecked();
11321140

@@ -1189,7 +1197,7 @@ describe('<CourseUnit />', () => {
11891197
name: unitInfoMessages.modalMakeVisibilityActionButtonText.defaultMessage,
11901198
}));
11911199

1192-
await waitFor(async() => {
1200+
await waitFor(async () => {
11931201
expect(visibilityCheckbox).not.toBeChecked();
11941202
});
11951203
expect(draftUnpublishedChangesHeading).toBeInTheDocument();
@@ -1302,19 +1310,15 @@ describe('<CourseUnit />', () => {
13021310
it('should toggle visibility from header configure modal and update course unit state accordingly', async () => {
13031311
const user = userEvent.setup();
13041312
render(<RootWrapper />);
1305-
let modalVisibilityCheckbox;
1306-
let configureModal;
1307-
let restrictAccessSelect;
1308-
13091313
expect(await within(await screen.findByTestId('course-unit-sidebar'))
13101314
.findByLabelText(unitInfoMessages.visibilityCheckboxTitle.defaultMessage)).not.toBeChecked();
13111315

13121316
const headerConfigureBtn = await screen.findByRole('button', { name: /settings/i });
13131317
expect(headerConfigureBtn).toBeInTheDocument();
13141318

13151319
await user.click(headerConfigureBtn);
1316-
configureModal = await screen.findByTestId('configure-modal');
1317-
restrictAccessSelect = await within(configureModal)
1320+
const configureModal = await screen.findByTestId('configure-modal');
1321+
const restrictAccessSelect = await within(configureModal)
13181322
.findByRole('combobox', { name: configureModalMessages.restrictAccessTo.defaultMessage });
13191323
expect(await within(configureModal)
13201324
.findByText(configureModalMessages.unitVisibility.defaultMessage)).toBeInTheDocument();
@@ -1323,7 +1327,7 @@ describe('<CourseUnit />', () => {
13231327
expect(restrictAccessSelect).toBeInTheDocument();
13241328
expect(restrictAccessSelect).toHaveValue('-1');
13251329

1326-
modalVisibilityCheckbox = await within(configureModal)
1330+
const modalVisibilityCheckbox = await within(configureModal)
13271331
.findByRole('checkbox', { name: configureModalMessages.hideFromLearners.defaultMessage });
13281332
expect(modalVisibilityCheckbox).not.toBeChecked();
13291333

@@ -2472,7 +2476,6 @@ describe('<CourseUnit />', () => {
24722476
},
24732477
});
24742478

2475-
24762479
// Move to settings and change visibility to all
24772480
const editVisibilityButton = await screen.findByRole('button', { name: /edit visibility/i });
24782481
await user.click(editVisibilityButton);
@@ -2483,7 +2486,7 @@ describe('<CourseUnit />', () => {
24832486
await user.click(detailsTab);
24842487

24852488
expect(
2486-
await screen.findByRole('heading', { name: /draft \(unpublished changes\)/i })
2489+
await screen.findByRole('heading', { name: /draft \(unpublished changes\)/i }),
24872490
).toBeInTheDocument();
24882491
});
24892492

‎src/course-unit/header-title/HeaderTitle.test.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ import { initializeMocks, render, screen } from '@src/testUtils';
44
import userEvent from '@testing-library/user-event';
55
import { executeThunk } from '@src/utils';
66

7+
import { IframeProvider } from '@src/generic/hooks/context/iFrameContext';
78
import { getCourseSectionVerticalApiUrl } from '../data/api';
89
import { fetchCourseSectionVerticalData } from '../data/thunk';
910
import { courseSectionVerticalMock } from '../__mocks__';
1011
import HeaderTitle from './HeaderTitle';
1112
import messages from './messages';
12-
import { IframeProvider } from '@src/generic/hooks/context/iFrameContext';
1313

1414
const blockId = '123';
1515
const unitTitle = 'Getting Started';
@@ -30,7 +30,7 @@ const renderComponent = (props?: any) => render(
3030
handleConfigureSubmit={handleConfigureSubmit}
3131
{...props}
3232
/>,
33-
</IframeProvider>
33+
</IframeProvider>,
3434
);
3535

3636
describe('<HeaderTitle />', () => {

‎src/course-unit/unit-sidebar/unit-info/UnitVisibilityInfo.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ import { getCourseUnitData } from '@src/course-unit/data/selectors';
99
import { PUBLISH_TYPES } from '@src/course-unit/constants';
1010
import { isUnitPageNewDesignEnabled } from '@src/course-unit/utils';
1111
import { Edit, Groups, Lock } from '@openedx/paragon/icons';
12+
import { useConfigureUnitWithPageUpdates } from '@src/course-unit/data/apiHooks';
1213
import messages from './messages';
1314
import { useUnitSidebarContext } from '../UnitSidebarContext';
14-
import { useConfigureUnitWithPageUpdates } from '@src/course-unit/data/apiHooks';
1515

1616
interface UnitVisibilityInfoProps {
1717
openVisibleModal: () => void,

‎src/generic/configure-modal/UnitTab.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,8 @@ export const AccessEditComponent = ({
105105
))}
106106
</Form.Control>
107107

108-
{selectedPartitionIndex !== undefined && selectedPartitionIndex >= 0 && userPartitionInfo?.selectablePartitions.length && (
108+
{selectedPartitionIndex !== undefined
109+
&& selectedPartitionIndex >= 0 && userPartitionInfo?.selectablePartitions.length && (
109110
<Form.Group controlId="select-groups-checkboxes">
110111
<Form.Label><FormattedMessage {...messages.unitSelectGroup} /></Form.Label>
111112
<div

0 commit comments

Comments
 (0)