Skip to content

Commit 1f1ece7

Browse files
committed
feat: Truncate titles in histoy log entries
1 parent 0881f5d commit 1f1ece7

3 files changed

Lines changed: 14 additions & 5 deletions

File tree

src/library-authoring/generic/history-log/HistoryLog.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
}
1111
}
1212

13+
.history-log-title {
14+
max-width: 250px;
15+
}
16+
1317
.history-log-vert {
1418
width: 8px;
1519
height: 2rem;

src/library-authoring/generic/history-log/HistoryLog.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ describe('<HistoryComponentLog />', () => {
4949

5050
it('renders draft history group with entries when they exist', async () => {
5151
renderComponent(mockLibraryBlockMetadata.usageKeyNeverPublished);
52-
const trigger = await screen.findByText('Test Component is a draft');
52+
const trigger = await findByTextContent(/Test Component is a draft/i);
5353
expect(trigger).toBeInTheDocument();
5454
fireEvent.click(trigger);
5555
expect(await findByTextContent(/test_user_1 edited.*Electron Arcs/i)).toBeInTheDocument();

src/library-authoring/generic/history-log/HistoryLogGroup.tsx

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ const HistoryLogGroupEntries = ({
124124
{...entryMessage}
125125
values={{
126126
user: entry.changedBy.username,
127-
displayName: entry.title,
127+
displayName: <span className="history-log-title text-truncate">{entry.title}</span>,
128128
icon: <Icon src={getItemIcon(entry.blockType)} />
129129
}}
130130
/>
@@ -155,7 +155,7 @@ export const HistoryCreatedLogGroup = ({
155155
<HistoryLogGroupTitle
156156
titleMessage={intl.formatMessage(messages.createdTitle, {
157157
user: user ?? intl.formatMessage(messages.historyEntryDefaultUser),
158-
displayName,
158+
displayName: <span className="history-log-title text-truncate">{displayName}</span>,
159159
icon: <Icon src={getItemIcon(itemType)} />,
160160
})}
161161
dateMessage={moment(createdAt).fromNow()}
@@ -176,7 +176,12 @@ export const HistoryDraftLogGroup = ({
176176
<Collapsible.Advanced>
177177
<Collapsible.Trigger>
178178
<HistoryLogGroupTitle
179-
titleMessage={intl.formatMessage(messages.draftTitle, { displayName })}
179+
titleMessage={intl.formatMessage(
180+
messages.draftTitle,
181+
{
182+
displayName: <span className="history-log-title text-truncate">{displayName}</span>
183+
}
184+
)}
180185
dateMessage={intl.formatMessage(
181186
messages.draftTitleDate,
182187
{
@@ -250,7 +255,7 @@ export const HistoryPublishLogGroup = ({
250255
messages.publishTitle,
251256
{
252257
user: publishedBy,
253-
displayName: title,
258+
displayName: <span className="history-log-title text-truncate">{title}</span>,
254259
icon: <Icon src={getItemIcon(blockType)} />
255260
},
256261
)}

0 commit comments

Comments
 (0)