Skip to content

Commit 0406210

Browse files
committed
Merge branch 'master' into chris/FAL-4266-import-from-course-stepper
2 parents 0c3cad3 + bd82c1d commit 0406210

142 files changed

Lines changed: 3243 additions & 1134 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.env

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,4 @@ LIBRARY_UNSUPPORTED_BLOCKS="conditional,step-builder,problem-builder"
4949
# Fallback in local style files
5050
PARAGON_THEME_URLS={}
5151
COURSE_TEAM_SUPPORT_EMAIL=''
52+
ADMIN_CONSOLE_URL='http://localhost:2025/admin-console'

.env.development

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,3 +52,4 @@ LIBRARY_UNSUPPORTED_BLOCKS="conditional,step-builder,problem-builder"
5252
# Fallback in local style files
5353
PARAGON_THEME_URLS={}
5454
COURSE_TEAM_SUPPORT_EMAIL=''
55+
ADMIN_CONSOLE_URL='http://localhost:2025/admin-console'

.eslintrc.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,15 @@ module.exports = createConfig(
1414
'no-restricted-exports': 'off',
1515
// There is no reason to disallow this syntax anymore; we don't use regenerator-runtime in new browsers
1616
'no-restricted-syntax': 'off',
17+
'no-restricted-imports': ['error', {
18+
patterns: [
19+
{
20+
group: ['@edx/frontend-platform/i18n'],
21+
importNames: ['injectIntl'],
22+
message: "Use 'useIntl' hook instead of injectIntl.",
23+
},
24+
],
25+
}],
1726
},
1827
settings: {
1928
// Import URLs should be resolved using aliases

.github/pull_request_template.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ We're trying to move away from some deprecated patterns in this codebase. Please
3030
check if your PR meets these recommendations before asking for a review:
3131

3232
- [ ] Any _new_ files are using TypeScript (`.ts`, `.tsx`).
33-
- [ ] Deprecated `propTypes`, `defaultProps`, and `injectIntl` patterns are not used in any new or modified code.
33+
- [ ] Avoid `propTypes` and `defaultProps` in any new or modified code.
3434
- [ ] Tests should use the helpers in `src/testUtils.tsx` (specifically `initializeMocks`)
3535
- [ ] Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
3636
- [ ] Use React Query to load data from REST APIs. See any `apiHooks.ts` in this repo for examples.
3737
- [ ] All new i18n messages in `messages.ts` files have a `description` for translators to use.
38-
- [ ] Imports avoid using `../`. To import from parent folders, use `@src`, e.g. `import { initializeMocks } from '@src/testUtils';` instead of `from '../../../../testUtils'`
38+
- [ ] Avoid using `../` in import paths. To import from parent folders, use `@src`, e.g. `import { initializeMocks } from '@src/testUtils';` instead of `from '../../../../testUtils'`

.github/workflows/validate.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
node-version-file: '.nvmrc'
1818
- run: make validate.ci
1919
- name: Archive code coverage results
20-
uses: actions/upload-artifact@v4
20+
uses: actions/upload-artifact@v5
2121
with:
2222
name: code-coverage-report
2323
path: coverage/*.*
@@ -27,7 +27,7 @@ jobs:
2727
steps:
2828
- uses: actions/checkout@v5
2929
- name: Download code coverage results
30-
uses: actions/download-artifact@v5
30+
uses: actions/download-artifact@v6
3131
with:
3232
pattern: code-coverage-report
3333
path: coverage

package-lock.json

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.3",
4646
"@edx/browserslist-config": "1.5.0",
4747
"@edx/frontend-component-footer": "^14.9.0",
48-
"@edx/frontend-component-header": "^8.0.0",
48+
"@edx/frontend-component-header": "^8.1.0",
4949
"@edx/frontend-enterprise-hotjar": "^7.2.0",
5050
"@edx/frontend-platform": "^8.4.0",
5151
"@edx/openedx-atlas": "^0.7.0",

plugins/course-apps/ora_settings/Settings.test.jsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,13 @@ describe('ORASettings', () => {
125125
});
126126

127127
it('Displays title, helper text and badge when flexible peer grading button is enabled', async () => {
128-
renderComponent();
129128
await mockStore({ apiStatus: 200, enabled: true });
129+
renderComponent();
130+
131+
const checkbox = await screen.getByRole('checkbox', { name: /Flex Peer Grading/ });
132+
expect(checkbox).toBeChecked();
130133

131-
waitFor(() => {
134+
await waitFor(() => {
132135
const label = screen.getByText(messages.enableFlexPeerGradeLabel.defaultMessage);
133136
const enableBadge = screen.getByTestId('enable-badge');
134137

0 commit comments

Comments
 (0)