When testing #10 locally I tried removing this line
|
// eslint-disable-next-line react/no-unstable-nested-components |
and running npm run lint to see the full error
104:19 error Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “TeamTable” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true react/no-unstable-nested-components
I then saw that this wasn't the first place in the file the rule was being ignored
|
// eslint-disable-next-line react/no-unstable-nested-components |
It'd be good to clean up any places we're ignoring this.
Relevant links:
When testing #10 locally I tried removing this line
frontend-app-admin-console/src/authz-module/libraries-manager/components/TeamTable.tsx
Line 104 in 16515df
and running
npm run lintto see the full errorI then saw that this wasn't the first place in the file the rule was being ignored
frontend-app-admin-console/src/authz-module/libraries-manager/components/TeamTable.tsx
Line 76 in 52fbb7e
It'd be good to clean up any places we're ignoring this.
Relevant links: