test: fix issues with failing tests

Author: bra-i-am

src/authz-module/data/hooks.test.tsx

@@ -59,7 +59,15 @@ describe('useTeamMembers', () => {
       get: jest.fn().mockResolvedValue({ data: { results: mockMembers } }),
     });
 
-    const { result } = renderHook(() => useTeamMembers('lib:123'), {
+    const mockQuerySettings = {
+      roles: null,
+      search: null,
+      ordering: null,
+      pageSize: 10,
+      pageIndex: 0,
+    };
+
+    const { result } = renderHook(() => useTeamMembers('lib:123', mockQuerySettings), {
       wrapper: createWrapper(),
     });
 
@@ -74,7 +82,15 @@ describe('useTeamMembers', () => {
       get: jest.fn().mockRejectedValue(new Error('API failure')),
     });
 
-    const { result } = renderHook(() => useTeamMembers('lib:123'), {
+    const mockQuerySettings = {
+      roles: null,
+      search: null,
+      ordering: null,
+      pageSize: 10,
+      pageIndex: 0,
+    };
+
+    const { result } = renderHook(() => useTeamMembers('lib:123', mockQuerySettings), {
       wrapper: createWrapper(),
     });
 

src/authz-module/data/hooks.ts

@@ -7,15 +7,15 @@ import {
 
 const authzQueryKeys = {
   all: [appId, 'authz'] as const,
-  teamMembers: (object: string, querySettings: QuerySettings) => [
+  teamMembers: (object: string, querySettings?: QuerySettings) => [
     ...authzQueryKeys.all,
     'teamMembers',
     object,
-    querySettings.roles,
-    querySettings.search,
-    querySettings.ordering,
-    querySettings.pageSize,
-    querySettings.pageIndex,
+    querySettings?.roles ?? null,
+    querySettings?.search ?? null,
+    querySettings?.ordering ?? null,
+    querySettings?.pageSize ?? 10,
+    querySettings?.pageIndex ?? 0,
   ] as const,
   permissionsByRole: (scope: string) => [...authzQueryKeys.all, 'permissionsByRole', scope] as const,
   library: (libraryId: string) => [...authzQueryKeys.all, 'library', libraryId] as const,

src/authz-module/libraries-manager/components/TeamTable.test.tsx

@@ -38,6 +38,11 @@ describe('TeamTable', () => {
     libraryId: 'lib:123',
     canManageTeam: true,
     username: 'alice',
+    roles: [
+      { name: 'Admin', role: 'admin', userCount: 1 },
+      { name: 'Editor', role: 'editor', userCount: 1 },
+      { name: 'Viewer', role: 'viewer', userCount: 1 },
+    ],
   };
 
   beforeEach(() => {
@@ -90,9 +95,7 @@ describe('TeamTable', () => {
     expect(editButtons).toHaveLength(1);
 
     await userEvent.click(editButtons[0]);
-    expect(mockNavigate).toHaveBeenCalledWith(
-      `/authz/${ROUTES.LIBRARIES_USER_PATH.replace(':username', 'bob')}`,
-    );
+    expect(mockNavigate).toHaveBeenCalledWith(`/authz/${ROUTES.LIBRARIES_USER_PATH.replace(':username', 'bob')}`);
   });
 
   it('does not render Edit button if canManageTeam is false', () => {

src/authz-module/libraries-manager/context.test.tsx

@@ -1,4 +1,5 @@
-import { screen } from '@testing-library/react';
+import { Component, ReactNode } from 'react';
+import { screen, renderHook } from '@testing-library/react';
 import { useParams } from 'react-router-dom';
 import { useValidateUserPermissions } from '@src/data/hooks';
 import { renderWrapper } from '@src/setupTest';
@@ -17,16 +18,31 @@ jest.mock('@src/authz-module/data/hooks', () => ({
     data: [
       {
         role: 'library_author',
-        permissions: [
-          'view_library_team',
-          'edit_library',
-        ],
+        permissions: ['view_library_team', 'edit_library'],
         user_count: 12,
       },
     ],
   }),
 }));
 
+class ErrorBoundary extends Component<{ children: ReactNode }, { hasError: boolean; error?: Error }> {
+  constructor(props: { children: ReactNode }) {
+    super(props);
+    this.state = { hasError: false };
+  }
+
+  static getDerivedStateFromError(error: Error) {
+    return { hasError: true, error };
+  }
+
+  render() {
+    if (this.state.hasError && this.state.error) {
+      throw this.state.error;
+    }
+    return this.props.children;
+  }
+}
+
 const TestComponent = () => {
   const context = useLibraryAuthZ();
   return (
@@ -35,7 +51,9 @@ const TestComponent = () => {
       <div data-testid="libraryId">{context.libraryId}</div>
       <div data-testid="canManageTeam">{context.canManageTeam ? 'true' : 'false'}</div>
       <div data-testid="roles">{Array.isArray(context.roles) ? context.roles.length : 'undefined'}</div>
-      <div data-testid="permissions">{Array.isArray(context.permissions) ? context.permissions.length : 'undefined'}</div>
+      <div data-testid="permissions">
+        {Array.isArray(context.permissions) ? context.permissions.length : 'undefined'}
+      </div>
       <div data-testid="resources">{Array.isArray(context.resources) ? context.resources.length : 'undefined'}</div>
     </div>
   );
@@ -108,21 +126,18 @@ describe('LibraryAuthZProvider', () => {
 
     expect(() => {
       renderWrapper(
-        <LibraryAuthZProvider>
-          <TestComponent />
-        </LibraryAuthZProvider>,
+        <ErrorBoundary>
+          <LibraryAuthZProvider>
+            <TestComponent />
+          </LibraryAuthZProvider>
+        </ErrorBoundary>,
       );
     }).toThrow('MissingLibrary');
   });
 
   it('throws error when useLibraryAuthZ is used outside provider', () => {
-    const BrokenComponent = () => {
-      useLibraryAuthZ();
-      return null;
-    };
-
     expect(() => {
-      renderWrapper(<BrokenComponent />);
+      renderHook(() => useLibraryAuthZ());
     }).toThrow('useLibraryAuthZ must be used within an LibraryAuthZProvider');
   });
 });