Skip to content

Commit e9e0bfc

Browse files
fix: minor issues after conflict solving
1 parent f99b977 commit e9e0bfc

5 files changed

Lines changed: 15 additions & 13 deletions

File tree

src/authz-module/authz-home/index.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React from 'react';
22
import { screen } from '@testing-library/react';
33
import { useAllRoleAssignments, useOrgs, useScopes } from '@src/authz-module/data/hooks';
4-
import { ToastManagerProvider } from '@src/authz-module/libraries-manager/ToastManagerContext';
4+
import { ToastManagerProvider } from '@src/authz-module/data/context/ToastManagerContext';
55
import { renderWithAllProviders } from '@src/setupTest';
66
import userEvent from '@testing-library/user-event';
77
import AuthzHome from './index';

src/authz-module/data/api.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -200,22 +200,22 @@ export const getScopes = async (search?: string, page?: number, pageSize?: numbe
200200
return camelCaseObject(data);
201201
};
202202

203-
export const getUserAssignedRoles = async (username: string, querySettings: QuerySettings)
203+
export const getUserAssignedRoles = async (username?: string, querySettings?: QuerySettings)
204204
: Promise<GetUserAssignmentsResponse> => {
205205
const url = new URL(getApiUrl(`/api/authz/v1/users/${username}/assignments/`));
206206

207-
if (querySettings.roles) {
207+
if (querySettings?.roles) {
208208
url.searchParams.set('roles', querySettings.roles);
209209
}
210-
if (querySettings.search) {
210+
if (querySettings?.search) {
211211
url.searchParams.set('search', querySettings.search);
212212
}
213-
if (querySettings.sortBy && querySettings.order) {
213+
if (querySettings?.sortBy && querySettings?.order) {
214214
url.searchParams.set('sort_by', querySettings.sortBy);
215-
url.searchParams.set('order', querySettings.order);
215+
url.searchParams.set('order', querySettings?.order || '');
216216
}
217-
url.searchParams.set('page_size', querySettings.pageSize.toString());
218-
url.searchParams.set('page', (querySettings.pageIndex + 1).toString());
217+
url.searchParams.set('page_size', querySettings?.pageSize?.toString() || '');
218+
url.searchParams.set('page', ((querySettings?.pageIndex ?? 0) + 1).toString());
219219

220220
const { data } = await getAuthenticatedHttpClient().get(url);
221221
return camelCaseObject(data);

src/authz-module/data/hooks.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const authzQueryKeys = {
2121
allRoleAssignments: (querySettings?: QuerySettings) => [...authzQueryKeys.all, 'allRoleAssignments', querySettings] as const,
2222
orgs: (search?: string, page?: number, pageSize?: number) => [...authzQueryKeys.all, 'organizations', search, page, pageSize] as const,
2323
scopes: (search?: string, page?: number, pageSize?: number) => [...authzQueryKeys.all, 'scopes', search, page, pageSize] as const,
24-
userRoles: (username: string, querySettings?: QuerySettings) => [...authzQueryKeys.all, 'userRoles', username, querySettings] as const,
24+
userRoles: (username?: string, querySettings?: QuerySettings) => [...authzQueryKeys.all, 'userRoles', username, querySettings] as const,
2525
};
2626

2727
/**
@@ -184,10 +184,12 @@ export const useScopes = (search?: string, page?: number, pageSize?: number) =>
184184
* ```
185185
*/
186186
export const useUserAssignedRoles = (
187-
username: string,
188-
querySettings: QuerySettings,
187+
username?: string,
188+
querySettings?: QuerySettings,
189189
) => useQuery<GetUserAssignmentsResponse, Error>({
190190
queryKey: authzQueryKeys.userRoles(username, querySettings),
191191
queryFn: () => getUserAssignedRoles(username, querySettings),
192192
staleTime: 1000 * 60 * 30, // refetch after 30 minutes
193+
enabled: !!username,
194+
refetchOnWindowFocus: false,
193195
});

src/authz-module/team-members/TeamMembersTable.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { screen, waitFor } from '@testing-library/react';
33
import userEvent from '@testing-library/user-event';
44
import { renderWithAllProviders } from '@src/setupTest';
55
import { useAllRoleAssignments, useOrgs, useScopes } from '@src/authz-module/data/hooks';
6-
import { ToastManagerProvider } from '@src/authz-module/libraries-manager/ToastManagerContext';
6+
import { ToastManagerProvider } from '@src/authz-module/data/context/ToastManagerContext';
77
import TeamMembersTable from './TeamMembersTable';
88

99
const mockedAllRoleAssignments = {

src/authz-module/team-members/TeamMembersTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
TextFilter,
77
} from '@openedx/paragon';
88

9-
import { useToastManager } from '@src/authz-module/libraries-manager/ToastManagerContext';
9+
import { useToastManager } from '@src/authz-module/data/context/ToastManagerContext';
1010
import { useQuerySettings } from '@src/authz-module/hooks/useQuerySettings';
1111
import OrgFilter from '@src/authz-module/components/TableControlBar/OrgFilter';
1212
import RolesFilter from '@src/authz-module/components/TableControlBar/RolesFilter';

0 commit comments

Comments
 (0)