style: update linter validation and fix lint issues

Author: dcoa

package.json

@@ -12,8 +12,8 @@
   "scripts": {
     "build": "fedx-scripts webpack",
     "i18n_extract": "fedx-scripts formatjs extract",
-    "lint": "fedx-scripts eslint --ext .js --ext .jsx .",
-    "lint:fix": "fedx-scripts eslint --fix --ext .js --ext .jsx .",
+    "lint": "fedx-scripts eslint --ext .js --ext .jsx --ext .ts --ext .tsx .",
+    "lint:fix": "fedx-scripts eslint --fix --ext .js --ext .jsx --ext .ts --ext .tsx .",
     "snapshot": "fedx-scripts jest --updateSnapshot",
     "start": "fedx-scripts webpack-dev-server --progress",
     "start:with-theme": "paragon install-theme && npm start && npm install",

src/authz-module/constants.ts

@@ -1,4 +1,4 @@
 export const ROUTES = {
   LIBRARIES_TEAM_PATH: '/libraries/:libraryId',
-  LIBRARIES_USER_PATH: '/libraries/user/:username'
-}; 
+  LIBRARIES_USER_PATH: '/libraries/user/:username',
+};

src/authz-module/data/api.ts

@@ -14,7 +14,6 @@ export const getTeamMembers = async (object: string): Promise<TeamMember[]> => {
   return camelCaseObject(data.results);
 };
 
-
 // TODO: this should be replaced in the future with Console API
 export const getLibrary = async (libraryId: string): Promise<LibraryMetadata> => {
   const { data } = await getAuthenticatedHttpClient().get(getStudioApiUrl(`/api/libraries/v2/${libraryId}/`));

src/authz-module/data/hooks.test.tsx

@@ -113,9 +113,9 @@ describe('useLibrary', () => {
 
     const wrapper = createWrapper();
     try {
-      act(()=>{
+      act(() => {
         renderHook(() => useLibrary('lib123'), { wrapper });
-      })
+      });
     } catch (e) {
       expect(e).toEqual(new Error('Not found'));
     }

src/authz-module/data/hooks.ts

@@ -3,7 +3,6 @@ import { appId } from '@src/constants';
 import { LibraryMetadata, TeamMember } from '@src/types';
 import { getLibrary, getTeamMembers } from './api';
 
-
 const authzQueryKeys = {
   all: [appId, 'authz'] as const,
   teamMembers: (object: string) => [...authzQueryKeys.all, 'teamMembers', object] as const,
@@ -36,10 +35,8 @@ export const useTeamMembers = (object: string) => useQuery<TeamMember[], Error>(
  * const { data } = useLibrary('lib:123',);
  *
  */
-export const useLibrary = (libraryId: string) => {
-  return useSuspenseQuery<LibraryMetadata, Error>({
-    queryKey: authzQueryKeys.library(libraryId),
-    queryFn: () => getLibrary(libraryId),
-    retry: false,
-  });
-}
+export const useLibrary = (libraryId: string) => useSuspenseQuery<LibraryMetadata, Error>({
+  queryKey: authzQueryKeys.library(libraryId),
+  queryFn: () => getLibrary(libraryId),
+  retry: false,
+});

src/authz-module/index.test.tsx

@@ -4,22 +4,16 @@ import { MemoryRouter } from 'react-router-dom';
 import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
 import AuthZModule from './index';
 
-jest.mock('./libraries-manager/LibrariesTeamManager', () => {
-  return lazy(() =>
-    new Promise<{ default: ComponentType<any> }>(resolve =>
-      setTimeout(() => resolve({ default: () => <div data-testid="libraries-manager">Loaded</div> }), 100)
-    )
-  );
-});
+// eslint-disable-next-line no-promise-executor-return
+jest.mock('./libraries-manager/LibrariesTeamManager', () => lazy(() => new Promise<{ default: ComponentType<any> }>(resolve => setTimeout(() => resolve({ default: () => <div data-testid="libraries-manager">Loaded</div> }), 100))));
 
-const createTestQueryClient = () =>
-  new QueryClient({
-    defaultOptions: {
-      queries: {
-        retry: false,
-      },
+const createTestQueryClient = () => new QueryClient({
+  defaultOptions: {
+    queries: {
+      retry: false,
     },
-  });
+  },
+});
 
 describe('AuthZModule', () => {
   it('renders LoadingPage then LibrariesTeamManager when route matches', async () => {
@@ -31,7 +25,7 @@ describe('AuthZModule', () => {
         <MemoryRouter initialEntries={[path]}>
           <AuthZModule />
         </MemoryRouter>
-      </QueryClientProvider>
+      </QueryClientProvider>,
     );
 
     expect(screen.getByTestId('loading-page')).toBeInTheDocument();

src/authz-module/index.tsx

@@ -2,7 +2,7 @@ import { Suspense } from 'react';
 import { Routes, Route } from 'react-router-dom';
 import { ErrorBoundary } from '@edx/frontend-platform/react';
 import LoadingPage from '@src/components/LoadingPage';
-import { LibrariesTeamManager } from './libraries-manager/';
+import { LibrariesTeamManager } from './libraries-manager';
 import { ROUTES } from './constants';
 
 import './index.scss';

src/authz-module/libraries-manager/LibrariesTeamManager.test.tsx

@@ -1,9 +1,9 @@
 import { screen } from '@testing-library/react';
-import LibrariesTeamManager from './LibrariesTeamManager';
-import { useLibraryAuthZ } from './context';
 import { renderWrapper } from '@src/setupTest';
 import { initializeMockApp } from '@edx/frontend-platform/testing';
 import { useLibrary } from '@src/authz-module/data/hooks';
+import { useLibraryAuthZ } from './context';
+import LibrariesTeamManager from './LibrariesTeamManager';
 
 jest.mock('./context', () => {
   const actual = jest.requireActual('./context');
@@ -28,9 +28,9 @@ describe('LibrariesTeamManager', () => {
   beforeEach(() => {
     initializeMockApp({
       authenticatedUser: {
-        username: 'admin'
-      }
-    })
+        username: 'admin',
+      },
+    });
     mockedUseLibraryAuthZ.mockReturnValue({
       libraryId: 'lib-001',
       libraryName: 'Mock Library',

src/authz-module/libraries-manager/LibrariesTeamManager.tsx

@@ -1,16 +1,16 @@
 import { useIntl } from '@edx/frontend-platform/i18n';
 import { Tab, Tabs } from '@openedx/paragon';
+import { useLibrary } from '@src/authz-module/data/hooks';
 import TeamTable from './components/TeamTable';
 import AuthZLayout from '../components/AuthZLayout';
-import { useLibrary } from '@src/authz-module/data/hooks';
 import { LibraryAuthZProvider, useLibraryAuthZ } from './context';
 
 import messages from './messages';
 
 const LibrariesAuthZTeamView = () => {
   const intl = useIntl();
   const { libraryId } = useLibraryAuthZ();
-  const { data: library } = useLibrary(libraryId)
+  const { data: library } = useLibrary(libraryId);
   const rootBradecrumb = intl.formatMessage(messages['library.authz.breadcrumb.root']) || '';
   const pageTitle = intl.formatMessage(messages['library.authz.manage.page.title']);
   return (

src/authz-module/libraries-manager/components/TeamTable.test.tsx

@@ -2,13 +2,13 @@ import { screen } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import { ROUTES } from '@src/authz-module/constants';
 import { renderWrapper } from '@src/setupTest';
-import TeamTable from './TeamTable';
 import { useTeamMembers } from '@src/authz-module/data/hooks';
+import TeamTable from './TeamTable';
 import { useLibraryAuthZ } from '../context';
 
 const mockNavigate = jest.fn();
-jest.mock('react-router', () => ({
-  ...jest.requireActual('react-router'),
+jest.mock('react-router-dom', () => ({
+  ...jest.requireActual('react-router-dom'),
   useNavigate: () => mockNavigate,
 }));
 
@@ -93,7 +93,7 @@ describe('TeamTable', () => {
 
     await userEvent.click(editButtons[0]);
     expect(mockNavigate).toHaveBeenCalledWith(
-      `/authz/${ROUTES.LIBRARIES_USER_PATH.replace(':username', 'alice')}`,
+      `/authz/${ROUTES.LIBRARIES_USER_PATH.replace(':username', 'bob')}`,
     );
   });