refactor: clean up tests and update navigation parameters for AddRoleButton

Author: bra-i-am

src/authz-module/authz-home/index.test.tsx

@@ -2,9 +2,8 @@ import React from 'react';
 import { screen } from '@testing-library/react';
 import { useAllRoleAssignments, useOrgs, useScopes } from '@src/authz-module/data/hooks';
 import { ToastManagerProvider } from '@src/authz-module/libraries-manager/ToastManagerContext';
-import { renderWithAllProviders, renderWrapper } from '@src/setupTest';
+import { renderWithAllProviders } from '@src/setupTest';
 import userEvent from '@testing-library/user-event';
-import { useNavigate } from 'react-router-dom';
 import AuthzHome from './index';
 import messages from './messages';
 
@@ -29,33 +28,6 @@ const renderAuthzHome = () => renderWithAllProviders(
   </ToastManagerProvider>,
 );
 
-jest.mock('../components/AuthZLayout', () => function MockAuthZLayout(
-  { children, actions }: { children: React.ReactNode; actions?: React.ReactNode[] },
-) {
-  return <div data-testid="authz-layout">{actions}{children}</div>;
-});
-
-jest.mock('../roles-permissions/RolesPermissions', () => function MockRolesPermissions() {
-  return <div data-testid="roles-permissions">Roles & Permissions Content</div>;
-});
-
-jest.mock('@openedx/paragon', () => ({
-  Tab: ({ children, title } : { children: React.ReactNode, title: string }) => <div data-testid="tab" role="tabpanel">{title}: {children}</div>,
-  Tabs: ({ children }: { children: React.ReactNode }) => <div data-testid="tabs">{children}</div>,
-  Button: ({ children, onClick }: React.PropsWithChildren<{ onClick?: () => void }>) => (
-    <button type="button" onClick={onClick}>{children}</button>
-  ),
-  Icon: () => null,
-}));
-
-jest.mock('react-router-dom', () => ({
-  ...jest.requireActual('react-router-dom'),
-  useNavigate: jest.fn(),
-}));
-
-const mockNavigate = jest.fn();
-(useNavigate as jest.Mock).mockReturnValue(mockNavigate);
-
 describe('AuthzHome', () => {
   beforeEach(() => {
     (useAllRoleAssignments as jest.Mock).mockReturnValue(emptyResponse);
@@ -99,11 +71,4 @@ describe('AuthzHome', () => {
     expect(screen.getAllByText('Role').length).toBe(2); // Header and role filter;
     expect(screen.getByText('Actions')).toBeInTheDocument();
   });
-
-  it('navigates to the wizard when the Assign Role button is clicked', async () => {
-    const user = userEvent.setup();
-    renderWrapper(<AuthzHome />);
-    await user.click(screen.getByRole('button', { name: /Assign Role/i }));
-    expect(mockNavigate).toHaveBeenCalled();
-  });
 });

src/authz-module/authz-home/messages.ts

@@ -21,11 +21,6 @@ const messages = defineMessages({
     defaultMessage: 'Roles and Permissions',
     description: 'AuthZ title for the roles tab',
   },
-  'authz.manage.assign.role.button': {
-    id: 'authz.manage.assign.role.button',
-    defaultMessage: 'Assign Role',
-    description: 'Button to navigate to the assign role wizard',
-  },
 });
 
 export default messages;

src/authz-module/components/AddRoleButton.test.tsx

@@ -76,7 +76,7 @@ describe('AddRoleButton', () => {
       await user.click(button);
 
       expect(mockNavigate).toHaveBeenCalledTimes(1);
-      expect(mockNavigate).toHaveBeenCalledWith(`/authz/assign-role?username=${presetUsername}`);
+      expect(mockNavigate).toHaveBeenCalledWith(`/authz/assign-role?users=${presetUsername}`);
     });
 
     it('handles special characters in presetUsername correctly', async () => {
@@ -88,7 +88,7 @@ describe('AddRoleButton', () => {
       await user.click(button);
 
       expect(mockNavigate).toHaveBeenCalledTimes(1);
-      expect(mockNavigate).toHaveBeenCalledWith(`/authz/assign-role?username=${presetUsername}`);
+      expect(mockNavigate).toHaveBeenCalledWith(`/authz/assign-role?${new URLSearchParams({ users: presetUsername }).toString()}`);
     });
   });
 
@@ -128,7 +128,7 @@ describe('AddRoleButton', () => {
       await user.click(button);
 
       expect(mockNavigate).toHaveBeenCalledTimes(3);
-      expect(mockNavigate).toHaveBeenCalledWith('/authz/assign-role?username=testuser');
+      expect(mockNavigate).toHaveBeenCalledWith('/authz/assign-role?users=testuser');
     });
   });
 });

src/authz-module/libraries-manager/LibrariesTeamManager.tsx

@@ -6,7 +6,7 @@ import {
 import { useLibrary } from '@src/authz-module/data/hooks';
 import { useLocation } from 'react-router-dom';
 import { ROUTES } from '@src/authz-module/constants';
-import AddRoleButton from 'authz-module/components/AddRoleButton';
+import AddRoleButton from '@src/authz-module/components/AddRoleButton';
 import TeamTable from './components/TeamTable';
 import AuthZLayout from '../components/AuthZLayout';
 import RoleCard from '../components/RoleCard';