refactor: separation of i18n messages

Author: dcoa

src/authz-module/libraries-manager/components/AssignNewRoleModal/AssignNewRoleModal.tsx

@@ -39,7 +39,7 @@ const AssignNewRoleModal: FC<AssignNewRoleModalProps> = ({
 
       <ModalDialog.Body className="my-4">
         <Form.Group controlId="role_options">
-          <Form.Label>{intl.formatMessage(messages['library.authz.team.table.roles'])}</Form.Label>
+          <Form.Label>{intl.formatMessage(messages['library.authz.manage.role.select.label'])}</Form.Label>
           <Form.Control as="select" name="role" value={selectedRole} onChange={handleChangeSelectedRole}>
             <option value="" disabled>Select a role</option>
             {roleOptions.map((role) => <option key={role.role} value={role.role}>{role.name}</option>)}

src/authz-module/libraries-manager/components/TeamTable/index.test.tsx

@@ -25,12 +25,12 @@ describe('TeamTable', () => {
     results: [
       {
         email: '[email protected]',
-        roles: ['Admin', 'Editor'],
+        roles: ['admin', 'editor'],
         username: 'alice',
       },
       {
         email: '[email protected]',
-        roles: ['Viewer'],
+        roles: ['viewer'],
         username: 'bob',
       },
     ],

src/authz-module/libraries-manager/components/TeamTable/messages.ts

@@ -31,31 +31,6 @@ const messages = defineMessages({
     defaultMessage: 'Edit',
     description: 'Edit action',
   },
-  'libraries.authz.manage.assign.new.role.title': {
-    id: 'libraries.authz.manage.assign.new.role.title',
-    defaultMessage: 'Add New Role',
-    description: 'Libraries AuthZ assign a new role to a user button title',
-  },
-  'libraries.authz.manage.cancel.button': {
-    id: 'libraries.authz.manage.cancel.button',
-    defaultMessage: 'Cancel',
-    description: 'Libraries AuthZ cancel button title',
-  },
-  'libraries.authz.manage.saving.button': {
-    id: 'libraries.authz.manage.saving.button',
-    defaultMessage: 'Saving...',
-    description: 'Libraries AuthZ saving button title',
-  },
-  'libraries.authz.manage.save.button': {
-    id: 'libraries.authz.manage.save.button',
-    defaultMessage: 'Save',
-    description: 'Libraries AuthZ save button title',
-  },
-  'libraries.authz.manage.assign.role.success': {
-    id: 'libraries.authz.manage.assign.role.success',
-    defaultMessage: 'Role added successfully.',
-    description: 'Libraries AuthZ assign role success message',
-  },
   'authz.libraries.team.table.search': {
     id: 'authz.libraries.team.table.search',
     defaultMessage: 'Search by {firstField} or {secondField}',
@@ -71,16 +46,6 @@ const messages = defineMessages({
     defaultMessage: 'Name Z-A',
     description: 'Sort by name Z-A',
   },
-  'authz.libraries.team.table.sort.newest': {
-    id: 'authz.libraries.team.table.sort.newest',
-    defaultMessage: 'Newest',
-    description: 'Sort by newest',
-  },
-  'authz.libraries.team.table.sort.oldest': {
-    id: 'authz.libraries.team.table.sort.oldest',
-    defaultMessage: 'Oldest',
-    description: 'Sort by oldest',
-  },
   'authz.libraries.team.table.clearFilters': {
     id: 'authz.libraries.team.table.clearFilters',
     defaultMessage: 'Clear filters',

src/authz-module/libraries-manager/components/messages.ts

@@ -0,0 +1,36 @@
+import { defineMessages } from '@edx/frontend-platform/i18n';
+
+const messages = defineMessages({
+  'libraries.authz.manage.assign.new.role.title': {
+    id: 'libraries.authz.manage.assign.new.role.title',
+    defaultMessage: 'Add New Role',
+    description: 'Libraries AuthZ assign a new role to a user button title',
+  },
+  'library.authz.manage.role.select.label': {
+    id: 'library.authz.role.select.label',
+    defaultMessage: 'Roles',
+    description: 'Libraries team management label for roles select',
+  },
+  'libraries.authz.manage.cancel.button': {
+    id: 'libraries.authz.manage.cancel.button',
+    defaultMessage: 'Cancel',
+    description: 'Libraries AuthZ cancel button title',
+  },
+  'libraries.authz.manage.saving.button': {
+    id: 'libraries.authz.manage.saving.button',
+    defaultMessage: 'Saving...',
+    description: 'Libraries AuthZ saving button title',
+  },
+  'libraries.authz.manage.save.button': {
+    id: 'libraries.authz.manage.save.button',
+    defaultMessage: 'Save',
+    description: 'Libraries AuthZ save button title',
+  },
+  'libraries.authz.manage.assign.role.success': {
+    id: 'libraries.authz.manage.assign.role.success',
+    defaultMessage: 'Role added successfully.',
+    description: 'Libraries AuthZ assign role success message',
+  },
+});
+
+export default messages;