Skip to content

Commit 7e3d853

Browse files
committed
refactor: update handleAddRole to display all roles
1 parent 8515b8d commit 7e3d853

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

src/authz-module/libraries-manager/components/AssignNewRoleTrigger.tsx

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Button, Toast, useToggle } from '@openedx/paragon';
44
import { Plus } from '@openedx/paragon/icons';
55

66
import { useLibraryAuthZ } from '@src/authz-module/libraries-manager/context';
7-
import { useAssignTeamMembersRole } from 'authz-module/data/hooks';
7+
import { useAssignTeamMembersRole } from '@src/authz-module/data/hooks';
88
import messages from './messages';
99
import AssignNewRoleModal from './AssignNewRoleModal';
1010

@@ -28,13 +28,19 @@ const AssignNewRoleTrigger: FC<AssignNewRoleTriggerProps> = ({
2828

2929
const { mutate: assignTeamMembersRole, isPending: isAssignTeamMembersRolePending } = useAssignTeamMembersRole();
3030

31-
const handleAddTeamMember = () => {
31+
const handleAddRole = () => {
3232
const data = {
3333
users: [username],
3434
role: newRole,
3535
scope: libraryId,
3636
};
3737

38+
if (currentUserRoles.includes(newRole)) {
39+
close();
40+
setNewRole('');
41+
return;
42+
}
43+
3844
assignTeamMembersRole({ data }, {
3945
onSuccess: () => {
4046
setToastMessage(
@@ -62,11 +68,12 @@ const AssignNewRoleTrigger: FC<AssignNewRoleTriggerProps> = ({
6268
<AssignNewRoleModal
6369
isOpen={isOpen}
6470
close={close}
65-
onSave={handleAddTeamMember}
71+
onSave={handleAddRole}
6672
isLoading={isAssignTeamMembersRolePending}
67-
roleOptions={roles.filter(role => !currentUserRoles.includes(role.role))}
73+
roleOptions={roles}
6874
selectedRole={newRole}
6975
handleChangeSelectedRole={(e) => setNewRole(e.target.value)}
76+
7077
/>
7178
)}
7279

0 commit comments

Comments
 (0)