refactor: replace useAddTeamMember with useAssignTeamMembersRole

Author: dcoa

src/authz-module/constants.ts

@@ -2,3 +2,11 @@ export const ROUTES = {
   LIBRARIES_TEAM_PATH: '/libraries/:libraryId',
   LIBRARIES_USER_PATH: '/libraries/user/:username',
 };
+
+export enum RoleOperationErrorStatus {
+  USER_NOT_FOUND = 'user_not_found',
+  USER_ALREADY_HAS_ROLE = 'user_already_has_role',
+  USER_DOES_NOT_HAVE_ROLE = 'user_does_not_have_role',
+  ROLE_ASSIGNMENT_ERROR = 'role_assignment_error',
+  ROLE_REMOVAL_ERROR = 'role_removal_error',
+}

src/authz-module/data/hooks.test.tsx

@@ -3,7 +3,7 @@ import { act, renderHook, waitFor } from '@testing-library/react';
 import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
 import { getAuthenticatedHttpClient } from '@edx/frontend-platform/auth';
 import {
-  useLibrary, usePermissionsByRole, useTeamMembers, useAddTeamMember,
+  useLibrary, usePermissionsByRole, useTeamMembers, useAssignTeamMembersRole,
 } from './hooks';
 
 jest.mock('@edx/frontend-platform/auth', () => ({
@@ -158,7 +158,7 @@ describe('usePermissionsByRole', () => {
     }
   });
 
-  describe('useAddTeamMember', () => {
+  describe('useAssignTeamMembersRole', () => {
     beforeEach(() => {
       jest.clearAllMocks();
     });
@@ -182,7 +182,7 @@ describe('usePermissionsByRole', () => {
         put: jest.fn().mockResolvedValue({ data: mockResponse }),
       });
 
-      const { result } = renderHook(() => useAddTeamMember(), {
+      const { result } = renderHook(() => useAssignTeamMembersRole(), {
         wrapper: createWrapper(),
       });
 
@@ -207,7 +207,7 @@ describe('usePermissionsByRole', () => {
         put: jest.fn().mockRejectedValue(new Error('Failed to add members')),
       });
 
-      const { result } = renderHook(() => useAddTeamMember(), {
+      const { result } = renderHook(() => useAssignTeamMembersRole(), {
         wrapper: createWrapper(),
       });
 

src/authz-module/data/hooks.ts

@@ -66,8 +66,8 @@ export const useLibrary = (libraryId: string) => useSuspenseQuery<LibraryMetadat
 });
 
 /**
- * React Query hook to add new team members to a specific library.
- * It provides a mutation function to add users with specified roles to the library's team.
+ * React Query hook to add new team members to a specific scope or manage the corresponding roles.
+ * It provides a mutation function to add users with specified roles to the team or assign new roles.
  *
  * @example
  * const { mutate: assignTeamMembersRole } = useAssignTeamMembersRole();

src/authz-module/libraries-manager/components/AddNewTeamMemberModal/AddNewTeamMemberModal.test.tsx

@@ -33,6 +33,7 @@ const defaultProps = {
 const mockRoles = [
   {
     role: 'instructor',
+    name: 'instructor',
     description: 'Can create and edit content',
     userCount: 3,
     objects: [
@@ -45,6 +46,7 @@ const mockRoles = [
   },
   {
     role: 'admin',
+    name: 'admin',
     description: 'Full access to the library',
     userCount: 1,
     objects: [

src/authz-module/libraries-manager/components/AddNewTeamMemberModal/AddNewTeamMemberModal.tsx

@@ -92,7 +92,7 @@ const AddNewTeamMemberModal: FC<AddNewTeamMemberModalProps> = ({
             state={isLoading ? 'pending' : 'default'}
             onClick={() => onSave()}
             disabledStates={['pending']}
-            disabled={!formValues.users || !formValues.role}
+            disabled={isLoading || !formValues.users || !formValues.role}
           />
         </ActionRow>
       </ModalDialog.Footer>

src/authz-module/libraries-manager/components/AddNewTeamMemberModal/AddNewTeamMemberTrigger.tsx

@@ -3,8 +3,9 @@ import { useIntl } from '@edx/frontend-platform/i18n';
 import { Button, Toast, useToggle } from '@openedx/paragon';
 import { Plus } from '@openedx/paragon/icons';
 
-import { useAssignTeamMembersRole } from '@src/authz-module/data/hooks';
 import { PutAssignTeamMembersRoleResponse } from 'authz-module/data/api';
+import { useAssignTeamMembersRole } from '@src/authz-module/data/hooks';
+import { RoleOperationErrorStatus } from '@src/authz-module/constants';
 import AddNewTeamMemberModal from './AddNewTeamMemberModal';
 import messages from './messages';
 
@@ -38,7 +39,8 @@ const AddNewTeamMemberTrigger: FC<AddNewTeamMemberTriggerProps> = ({
 
   const handleErrors = (errors: PutAssignTeamMembersRoleResponse['errors']) => {
     setIsError(false);
-    const notFoundUsers = errors.filter(err => err.error === 'user_not_found').map(err => err.userIdentifier);
+    const notFoundUsers = errors.filter(err => err.error === RoleOperationErrorStatus.USER_NOT_FOUND)
+      .map(err => err.userIdentifier);
 
     if (notFoundUsers.length) {
       setIsError(true);
@@ -91,9 +93,10 @@ const AddNewTeamMemberTrigger: FC<AddNewTeamMemberTriggerProps> = ({
   };
   const handleClose = () => {
     setFormValues(DEFAULT_FORM_VALUES);
-    setIsError(false)
+    setIsError(false);
     close();
-  }
+  };
+
   return (
     <>
       <Button