refactor: address feedback

Author: bra-i-am

src/authz-module/constants.ts

@@ -1,4 +1,4 @@
-import { PermissionMetadata, ResourceMetadata, RoleMetadata } from 'types';
+import { PermissionMetadata, ResourceMetadata } from 'types';
 
 export const CONTENT_LIBRARY_PERMISSIONS = {
   DELETE_LIBRARY: 'content_libraries.delete_library',
@@ -62,23 +62,6 @@ export const CONTENT_COURSE_PERMISSIONS = {
   VIEW_COURSE_GLOBAL_STAFF_SUPER_ADMINS: 'courses.view_global_staff_and_superadmins',
 };
 
-// Note: this information will eventually come from the backend API
-// but for the MVP we decided to manage it in the frontend
-export const libraryRolesMetadata: RoleMetadata[] = [
-  {
-    role: 'library_admin', name: 'Library Admin', description: 'The Library Admin has full control over the library, including managing users, modifying content, and handling publishing workflows. They ensure content is properly maintained and accessible as needed.', contextType: 'library',
-  },
-  {
-    role: 'library_author', name: 'Library Author', description: 'The Library Author is responsible for creating, editing, and publishing content within a library. They can manage tags and collections but cannot delete libraries or manage users.', contextType: 'library',
-  },
-  {
-    role: 'library_contributor', name: 'Library Contributor', description: 'The Library Contributor can create and edit content within a library but cannot publish it. They support the authoring process while leaving final publishing to Authors or Admins.', contextType: 'library',
-  },
-  {
-    role: 'library_user', name: 'Library User', description: 'The Library User can view and reuse content but cannot edit or delete any resource.', contextType: 'library',
-  },
-];
-
 export const libraryResourceTypes: ResourceMetadata[] = [
   { key: 'library', label: 'Library', description: 'Permissions related to the library as a whole.' },
   { key: 'library_content', label: 'Content', description: 'Permissions to create, edit, delete, and publish individual content items within the library.' },
@@ -160,51 +143,6 @@ export const DJANGO_MANAGED_ROLES = ['django.superuser', 'django.globalstaff'];
 export const TABLE_DEFAULT_PAGE_SIZE = 10;
 
 export const DEFAULT_FILTER_PAGE_SIZE = 5;
-// Course Permission Keys
-export const COURSE_PERMISSIONS = {
-  // View permissions (Course Auditor)
-  VIEW_COURSE: 'courses.view_course',
-  VIEW_COURSE_UPDATES: 'courses.view_course_updates',
-  VIEW_PAGES_AND_RESOURCES: 'courses.view_pages_and_resources',
-  VIEW_FILES: 'courses.view_files',
-  VIEW_GRADING_SETTINGS: 'courses.view_grading_settings',
-  VIEW_CHECKLISTS: 'courses.view_checklists',
-  VIEW_COURSE_TEAM: 'courses.view_course_team',
-  VIEW_SCHEDULE_AND_DETAILS: 'courses.view_schedule_and_details',
-
-  // Edit permissions (Course Editor)
-  EDIT_COURSE_CONTENT: 'courses.edit_course_content',
-  MANAGE_LIBRARY_UPDATES: 'courses.manage_library_updates',
-  MANAGE_COURSE_UPDATES: 'courses.manage_course_updates',
-  MANAGE_PAGES_AND_RESOURCES: 'courses.manage_pages_and_resources',
-  CREATE_FILES: 'courses.create_files',
-  EDIT_FILES: 'courses.edit_files',
-  EDIT_GRADING_SETTINGS: 'courses.edit_grading_settings',
-  MANAGE_GROUP_CONFIGURATIONS: 'courses.manage_group_configurations',
-  EDIT_DETAILS: 'courses.edit_details',
-  MANAGE_TAGS: 'courses.manage_tags',
-
-  // Publish & lifecycle permissions (Course Staff)
-  PUBLISH_COURSE_CONTENT: 'courses.publish_course_content',
-  DELETE_FILES: 'courses.delete_files',
-  EDIT_SCHEDULE: 'courses.edit_schedule',
-  MANAGE_ADVANCED_SETTINGS: 'courses.manage_advanced_settings',
-  MANAGE_CERTIFICATES: 'courses.manage_certificates',
-  IMPORT_COURSE: 'courses.import_course',
-  EXPORT_COURSE: 'courses.export_course',
-  EXPORT_TAGS: 'courses.export_tags',
-
-  // Team & taxonomy permissions (Course Admin only)
-  MANAGE_COURSE_TEAM: 'courses.manage_course_team',
-  MANAGE_TAXONOMIES: 'courses.manage_taxonomies',
-
-  // Legacy role permissions
-  LEGACY_STAFF_ROLE_PERMISSIONS: 'courses.legacy_staff_role_permissions',
-  LEGACY_INSTRUCTOR_ROLE_PERMISSIONS: 'courses.legacy_instructor_role_permissions',
-  LEGACY_LIMITED_STAFF_ROLE_PERMISSIONS: 'courses.legacy_limited_staff_role_permissions',
-  LEGACY_DATA_RESEARCHER_PERMISSIONS: 'courses.legacy_data_researcher_permissions',
-  LEGACY_BETA_TESTER_PERMISSIONS: 'courses.legacy_beta_tester_permissions',
-};
 
 // Resource Type Definitions
 export const RESOURCE_TYPES = {

src/authz-module/index.scss

@@ -75,6 +75,43 @@
   }
 }
 
+.highlighted-users-input {
+  &__layer {
+    font-family: inherit;
+    font-size: 1rem;
+    line-height: 1.5;
+    padding: 0.375rem 0.75rem;
+    white-space: pre-wrap;
+    word-break: break-word;
+    overflow-wrap: break-word;
+    width: 100%;
+  }
+
+  &__overlay {
+    position: absolute;
+    inset: 0;
+    background: #fff;
+    border: 1px solid transparent;
+    border-radius: 0.25rem;
+    overflow: hidden;
+    pointer-events: none;
+    z-index: 0;
+  }
+
+  &__textarea {
+    position: relative;
+    z-index: 1;
+    min-height: 100px;
+    resize: vertical;
+    caret-color: #212529;
+
+    &--highlighted {
+      color: transparent;
+      background: transparent;
+    }
+  }
+}
+
 .toast-container {
   // Ensure toast appears above modal
   z-index: 1000;

src/authz-module/index.tsx

@@ -9,7 +9,7 @@ import { ToastManagerProvider } from './libraries-manager/ToastManagerContext';
 import { LibrariesUserManager, LibrariesLayout, LibrariesTeamManager } from './libraries-manager';
 import AuthzHome from './authz-home';
 import AuditUserPage from './audit-user';
-import AssignRoleWizardPage from './wizard/AssignRoleWizardPage';
+import AssignRoleWizardPage from './role-assignation-wizard/AssignRoleWizardPage';
 import { ROUTES } from './constants';
 
 import './index.scss';

src/authz-module/libraries-manager/context.tsx

@@ -8,8 +8,9 @@ import { usePermissionsByRole } from '@src/authz-module/data/hooks';
 import { PermissionMetadata, ResourceMetadata, Role } from 'types';
 import { CustomErrors } from '@src/constants';
 import {
-  CONTENT_LIBRARY_PERMISSIONS, libraryPermissions, libraryResourceTypes, libraryRolesMetadata,
+  CONTENT_LIBRARY_PERMISSIONS, libraryPermissions, libraryResourceTypes,
 } from '../constants';
+import { libraryRolesMetadata } from '../roles-permissions/library/constants';
 
 const LIBRARY_TEAM_PERMISSIONS = [
   CONTENT_LIBRARY_PERMISSIONS.VIEW_LIBRARY_TEAM,

src/authz-module/libraries-manager/messages.ts

@@ -106,11 +106,6 @@ const messages = defineMessages({
     defaultMessage: 'Retry',
     description: 'Label for retry button.',
   },
-  'library.authz.manage.assign.role.wizard.button': {
-    id: 'library.authz.manage.assign.role.wizard.button',
-    defaultMessage: 'Assign Role',
-    description: 'Button to open the assign-role wizard with the current user pre-filled.',
-  },
 });
 
 export default messages;

…-module/wizard/AssignRoleWizard.test.tsx …gnation-wizard/AssignRoleWizard.test.tsxsrc/authz-module/wizard/AssignRoleWizard.test.tsx renamed to src/authz-module/role-assignation-wizard/AssignRoleWizard.test.tsx src/authz-module/wizard/AssignRoleWizard.test.tsx renamed to src/authz-module/role-assignation-wizard/AssignRoleWizard.test.tsx

@@ -34,6 +34,20 @@ interface AssignRoleWizardProps {
   roles?: RoleMetadata[];
 }
 
+const parseUsers = (input: string): string[] => input
+  .split(',')
+  .map((u) => u.trim())
+  .filter(Boolean);
+
+const getInitialState = (initialUsers: string) => ({
+  activeStep: STEPS.SELECT_USERS_AND_ROLE as StepKey,
+  users: initialUsers,
+  selectedRole: null as string | null,
+  selectedScopes: new Set<string>(),
+  invalidUsers: [] as string[],
+  validatedUsers: [] as string[],
+});
+
 const AssignRoleWizard = ({ onClose, initialUsers = '', roles = allRolesMetadata }: AssignRoleWizardProps) => {
   const intl = useIntl();
   const { showErrorToast } = useToastManager();
@@ -42,7 +56,6 @@ const AssignRoleWizard = ({ onClose, initialUsers = '', roles = allRolesMetadata
   const [selectedRole, setSelectedRole] = useState<string | null>(null);
   const [selectedScopes, setSelectedScopes] = useState<Set<string>>(new Set());
 
-  const [validationError, setValidationError] = useState<string | null>(null);
   const [invalidUsers, setInvalidUsers] = useState<string[]>([]);
   const [validatedUsers, setValidatedUsers] = useState<string[]>([]);
 
@@ -52,31 +65,25 @@ const AssignRoleWizard = ({ onClose, initialUsers = '', roles = allRolesMetadata
 
   const handleUsersChange = useCallback((value: string) => {
     setInvalidUsers((prev) => (prev.length > 0 ? [] : prev));
-    setValidationError(null);
     setUsers(value);
   }, []);
 
   const handleClose = () => {
-    setActiveStep(STEPS.SELECT_USERS_AND_ROLE);
-    setUsers('');
-    setSelectedRole(null);
-    setSelectedScopes(new Set());
-    setValidationError(null);
-    setInvalidUsers([]);
-    setValidatedUsers([]);
+    const initialState = getInitialState(initialUsers);
+    setActiveStep(initialState.activeStep);
+    setUsers(initialState.users);
+    setSelectedRole(initialState.selectedRole);
+    setSelectedScopes(initialState.selectedScopes);
+    setInvalidUsers(initialState.invalidUsers);
+    setValidatedUsers(initialState.validatedUsers);
     onClose();
   };
 
-  const parseUsers = (input: string): string[] => input
-    .split(',')
-    .map((u) => u.trim())
-    .filter(Boolean);
-
   const validateUsersAndProceed = async () => {
+    if (validateUsersMutation.isPending) { return; }
     const usersList = parseUsers(users);
     if (usersList.length === 0 || !selectedRole) { return; }
 
-    setValidationError(null);
     setInvalidUsers([]);
 
     try {
@@ -88,7 +95,6 @@ const AssignRoleWizard = ({ onClose, initialUsers = '', roles = allRolesMetadata
         setActiveStep(STEPS.DEFINE_APPLICATION_SCOPE);
       }
     } catch (error) {
-      setValidationError(intl.formatMessage(messages['wizard.validate.error']));
       showErrorToast(error, validateUsersAndProceed);
     }
   };
@@ -107,15 +113,14 @@ const AssignRoleWizard = ({ onClose, initialUsers = '', roles = allRolesMetadata
     handleClose();
   };
 
-  const isError = invalidUsers.length > 0 || !!validationError;
-
   useEffect(() => {
-    if (isError && usersInputRef.current) {
+    if (invalidUsers.length && usersInputRef.current) {
       usersInputRef.current.scrollIntoView({ behavior: 'smooth', block: 'center' });
     }
-  }, [isError]);
+  }, [invalidUsers]);
 
-  const canProceed = !!users.trim() && !!selectedRole;
+  const parsedUsers = parseUsers(users);
+  const canProceed = parsedUsers.length > 0 && !!selectedRole;
   const canSave = selectedScopes.size > 0;
 
   return (
@@ -126,6 +131,9 @@ const AssignRoleWizard = ({ onClose, initialUsers = '', roles = allRolesMetadata
         <Stepper.Step
           eventKey={STEPS.SELECT_USERS_AND_ROLE}
           title={intl.formatMessage(messages['wizard.step.selectUsersAndRole.title'])}
+          hasError={invalidUsers.length > 0}
+          description={invalidUsers.length > 0 ? intl.formatMessage(messages['wizard.step.selectUsersAndRole.error']) : ''}
+          index={0}
         >
           <SelectUsersAndRoleStep
             users={users}
@@ -141,6 +149,7 @@ const AssignRoleWizard = ({ onClose, initialUsers = '', roles = allRolesMetadata
         <Stepper.Step
           eventKey={STEPS.DEFINE_APPLICATION_SCOPE}
           title={intl.formatMessage(messages['wizard.step.defineScope.title'])}
+          index={1}
         >
           <DefineApplicationScopeStep
             selectedRole={selectedRole}
@@ -162,7 +171,7 @@ const AssignRoleWizard = ({ onClose, initialUsers = '', roles = allRolesMetadata
               pending: intl.formatMessage(messages['wizard.button.next.pending']),
             }}
             icons={{ pending: <Icon src={SpinnerSimple} /> }}
-            variant={isError ? 'danger' : 'primary'}
+            variant={invalidUsers.length ? 'danger' : 'primary'}
             state={validateUsersMutation.isPending ? 'pending' : 'default'}
             onClick={validateUsersAndProceed}
             disabled={!canProceed || validateUsersMutation.isPending}

…authz-module/wizard/AssignRoleWizard.tsx …-assignation-wizard/AssignRoleWizard.tsxsrc/authz-module/wizard/AssignRoleWizard.tsx renamed to src/authz-module/role-assignation-wizard/AssignRoleWizard.tsx src/authz-module/wizard/AssignRoleWizard.tsx renamed to src/authz-module/role-assignation-wizard/AssignRoleWizard.tsx

@@ -11,7 +11,7 @@ const AssignRoleWizardPage = () => {
   const [searchParams] = useSearchParams();
   const initialUsers = searchParams.get('users') || '';
   const raw = searchParams.get('from') ?? '';
-  const returnTo = raw.startsWith('/') ? raw : ROUTES.HOME_PATH;
+  const returnTo = (raw.startsWith('/') && !raw.startsWith('//')) ? raw : ROUTES.HOME_PATH;
 
   return (
     <AuthZLayout