repo_apk: move entry size limit to the top of the file

mlschroe · mlschroe · commit f8a299cd6317 · 2025-08-05T11:59:35.000+02:00
diff --git a/ext/repo_apk.c b/ext/repo_apk.c
@@ -26,6 +26,8 @@
 #include "repo_apk.h"
 #include "repo_apkv3.h"
 
+#define MAX_ENTRY_SIZE        0x1000000
+
 static inline ssize_t
 apk_fillbuf(unsigned char *buf, size_t count, int fd, FILE *fp)
 {
@@ -453,7 +455,7 @@ repo_add_apk_pkg(Repo *repo, const char *fn, int flags)
 	  tarhead_skip(&th);
 	  continue;
 	}
-      if (th.length > 10 * 1024 * 1024)
+      if (th.length >= MAX_ENTRY_SIZE)
 	{
 	  pool_error(pool, -1, "%s: oversized .PKGINFO", fn);
 	  break;

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,8 @@`
`26`	`26`	`#include "repo_apk.h"`
`27`	`27`	`#include "repo_apkv3.h"`
`28`	`28`
	`29`	`+#define MAX_ENTRY_SIZE 0x1000000`
	`30`	`+`
`29`	`31`	`static inline ssize_t`
`30`	`32`	`apk_fillbuf(unsigned char buf, size_t count, int fd, FILE fp)`
`31`	`33`	`{`
`@@ -453,7 +455,7 @@ repo_add_apk_pkg(Repo repo, const char fn, int flags)`
`453`	`455`	`tarhead_skip(&th);`
`454`	`456`	`continue;`
`455`	`457`	`}`
`456`		`- if (th.length > 10 * 1024 * 1024)`
	`458`	`+ if (th.length >= MAX_ENTRY_SIZE)`
`457`	`459`	`{`
`458`	`460`	`pool_error(pool, -1, "%s: oversized .PKGINFO", fn);`
`459`	`461`	`break;`