Make repo line parsing not crash if the last argument is missing

mlschroe · mlschroe · commit 9d53fe7416fc · 2021-09-25T23:09:44.000+02:00
Fixes issue #473.
diff --git a/ext/testcase.c b/ext/testcase.c
@@ -2096,7 +2096,7 @@ testcase_read(Pool *pool, FILE *fp, const char *testcase, Queue *job, char **res
 	    }
           repo->priority = prio;
           repo->subpriority = subprio;
-	  if (strcmp(pieces[3], "empty") != 0)
+	  if (strcmp(pieces[3], "empty") != 0 && npieces > 4)
 	    {
 	      const char *repotype = pool_tmpjoin(pool, pieces[3], 0, 0);	/* gets overwritten in <inline> case */
 	      if (!strcmp(pieces[4], "<inline>"))

Original file line number	Diff line number	Diff line change
`@@ -2096,7 +2096,7 @@ testcase_read(Pool pool, FILE fp, const char testcase, Queue job, char **res`
`2096`	`2096`	`}`
`2097`	`2097`	`repo->priority = prio;`
`2098`	`2098`	`repo->subpriority = subprio;`
`2099`		`- if (strcmp(pieces[3], "empty") != 0)`
	`2099`	`+ if (strcmp(pieces[3], "empty") != 0 && npieces > 4)`
`2100`	`2100`	`{`
`2101`	`2101`	`const char repotype = pool_tmpjoin(pool, pieces[3], 0, 0); / gets overwritten in <inline> case */`
`2102`	`2102`	`if (!strcmp(pieces[4], "<inline>"))`