Skip to content

Commit 8f3aed5

Browse files
committed
Ignore constrains conflicting with itself, tweak constrains problem message
1 parent 8bbe0c4 commit 8f3aed5

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

src/problems.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1343,7 +1343,7 @@ solver_problemruleinfo2str(Solver *solv, SolverRuleinfo type, Id source, Id targ
13431343
return pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), " can only be installed by a direct request");
13441344
case SOLVER_RULE_PKG_CONSTRAINS:
13451345
s = pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), 0);
1346-
s = pool_tmpappend(pool, s, " has a constraint ", pool_dep2str(pool, dep));
1346+
s = pool_tmpappend(pool, s, " has constraint ", pool_dep2str(pool, dep));
13471347
return pool_tmpappend(pool, s, " conflicting with ", pool_solvid2str(pool, target));
13481348
default:
13491349
return "bad problem rule type";

src/rules.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -679,6 +679,8 @@ add_conda_constrains_rule(Solver *solv, Id n, Id dep)
679679
FOR_PROVIDES(p, pp, rd->name)
680680
{
681681
Id p2;
682+
if (p == n)
683+
continue;
682684
while ((p2 = pool->whatprovidesdata[pdep]) != 0 && p2 < p)
683685
pdep++;
684686
if (p == p2)

0 commit comments

Comments
 (0)