Also use unsigned int when bounds checking pool_arch2color()

mlschroe · mlschroe · commit 2d8b2509c795 · 2018-07-24T13:37:47.000+02:00
This is done so that the code doesn't crash when you pass
a rel id.
diff --git a/src/poolarch.h b/src/poolarch.h
@@ -24,7 +24,7 @@ extern unsigned char pool_arch2color_slow(Pool *pool, Id arch);
 
 static inline unsigned char pool_arch2color(Pool *pool, Id arch)
 {
-  if (arch >= pool->lastarch)
+  if ((unsigned int)arch >= (unsigned int)pool->lastarch)
     return ARCHCOLOR_ALL;
   if (pool->id2color && pool->id2color[arch])
     return pool->id2color[arch];

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ extern unsigned char pool_arch2color_slow(Pool *pool, Id arch);`
`24`	`24`
`25`	`25`	`static inline unsigned char pool_arch2color(Pool *pool, Id arch)`
`26`	`26`	`{`
`27`		`- if (arch >= pool->lastarch)`
	`27`	`+ if ((unsigned int)arch >= (unsigned int)pool->lastarch)`
`28`	`28`	`return ARCHCOLOR_ALL;`
`29`	`29`	`if (pool->id2color && pool->id2color[arch])`
`30`	`30`	`return pool->id2color[arch];`