Skip to content

Commit 2d5af5b

Browse files
committed
Fix library type of tcl binding
Building the tcl binding as a SHARED type library means that an INSTALL of that target is treated as a RUNTIME target on DLL platforms, which currently has no DESTINATION provided. Change the type to MODULE (the same as other bindings), as an INSTALL of a target of that type uses the LIBRARY target on all platforms.
1 parent 95de14f commit 2d5af5b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

bindings/tcl/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ ADD_CUSTOM_COMMAND (
2121
ADD_DEFINITIONS(-Wno-unused)
2222
INCLUDE_DIRECTORIES (${TCL_INCLUDE_PATH})
2323

24-
ADD_LIBRARY (bindings_tcl SHARED solv_tcl.c)
24+
ADD_LIBRARY (bindings_tcl MODULE solv_tcl.c)
2525
SET_TARGET_PROPERTIES (bindings_tcl PROPERTIES PREFIX "" OUTPUT_NAME "solv-${VERSION}" INSTALL_NAME_DIR "${TCL_INSTALL_DIR}")
2626
TARGET_LINK_LIBRARIES (bindings_tcl libsolvext libsolv ${TCL_LIBRARY} ${SYSTEM_LIBRARIES})
2727
INSTALL (TARGETS bindings_tcl LIBRARY DESTINATION ${TCL_INSTALL_DIR})

0 commit comments

Comments
 (0)