Skip to content

Commit 2c33cda

Browse files
committed
Rename collhandle to more accurate collpkg
1 parent 956cb2d commit 2c33cda

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

ext/repo_updateinfoxml.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ struct parsedata {
110110
Id handle;
111111
Solvable *solvable;
112112
time_t buildtime;
113-
Id collhandle;
113+
Id pkghandle;
114114
struct solv_xmlparser xmlp;
115115
struct joindata jd;
116116
};
@@ -326,12 +326,12 @@ startElement(struct solv_xmlparser *xmlp, int state, const char *name, const cha
326326
solvable->conflicts = repo_addid_dep(pd->repo, solvable->conflicts, id, 0);
327327
}
328328

329-
/* who needs the collection anyway? */
330-
pd->collhandle = repodata_new_handle(pd->data);
331-
repodata_set_id(pd->data, pd->collhandle, UPDATE_COLLECTION_NAME, n);
332-
repodata_set_id(pd->data, pd->collhandle, UPDATE_COLLECTION_EVR, evr);
329+
/* UPDATE_COLLECTION is misnamed, it should have been UPDATE_PACKAGE */
330+
pd->pkghandle = repodata_new_handle(pd->data);
331+
repodata_set_id(pd->data, pd->pkghandle, UPDATE_COLLECTION_NAME, n);
332+
repodata_set_id(pd->data, pd->pkghandle, UPDATE_COLLECTION_EVR, evr);
333333
if (a)
334-
repodata_set_id(pd->data, pd->collhandle, UPDATE_COLLECTION_ARCH, a);
334+
repodata_set_id(pd->data, pd->pkghandle, UPDATE_COLLECTION_ARCH, a);
335335
break;
336336
}
337337
case STATE_MODULE:
@@ -428,14 +428,14 @@ endElement(struct solv_xmlparser *xmlp, int state, char *content)
428428
break;
429429

430430
case STATE_PACKAGE:
431-
repodata_add_flexarray(pd->data, pd->handle, UPDATE_COLLECTION, pd->collhandle);
432-
pd->collhandle = 0;
431+
repodata_add_flexarray(pd->data, pd->handle, UPDATE_COLLECTION, pd->pkghandle);
432+
pd->pkghandle = 0;
433433
break;
434434

435435
/* <filename>libntlm-0.4.2-1.fc8.x86_64.rpm</filename> */
436436
/* <filename>libntlm-0.4.2-1.fc8.x86_64.rpm</filename> */
437437
case STATE_FILENAME:
438-
repodata_set_str(pd->data, pd->collhandle, UPDATE_COLLECTION_FILENAME, content);
438+
repodata_set_str(pd->data, pd->pkghandle, UPDATE_COLLECTION_FILENAME, content);
439439
break;
440440

441441
/* <reboot_suggested>True</reboot_suggested> */
@@ -444,7 +444,7 @@ endElement(struct solv_xmlparser *xmlp, int state, char *content)
444444
{
445445
/* FIXME: this is per-package, the global flag should be computed at runtime */
446446
repodata_set_void(pd->data, pd->handle, UPDATE_REBOOT);
447-
repodata_set_void(pd->data, pd->collhandle, UPDATE_REBOOT);
447+
repodata_set_void(pd->data, pd->pkghandle, UPDATE_REBOOT);
448448
}
449449
break;
450450

@@ -454,7 +454,7 @@ endElement(struct solv_xmlparser *xmlp, int state, char *content)
454454
{
455455
/* FIXME: this is per-package, the global flag should be computed at runtime */
456456
repodata_set_void(pd->data, pd->handle, UPDATE_RESTART);
457-
repodata_set_void(pd->data, pd->collhandle, UPDATE_RESTART);
457+
repodata_set_void(pd->data, pd->pkghandle, UPDATE_RESTART);
458458
}
459459
break;
460460

@@ -464,7 +464,7 @@ endElement(struct solv_xmlparser *xmlp, int state, char *content)
464464
{
465465
/* FIXME: this is per-package, the global flag should be computed at runtime */
466466
repodata_set_void(pd->data, pd->handle, UPDATE_RELOGIN);
467-
repodata_set_void(pd->data, pd->collhandle, UPDATE_RELOGIN);
467+
repodata_set_void(pd->data, pd->pkghandle, UPDATE_RELOGIN);
468468
}
469469
break;
470470
default:

0 commit comments

Comments
 (0)