Skip to content

Commit 19d7cc8

Browse files
author
Alejandro del Castillo
committed
solver_solve: only disfavor recommends if there are any
In a repo that have pkg 'a' and 'b' available, and 'b' is disfavored, but 'a' doesn't recommend 'b', libsolv segfaults on solver_addrecommendsrules, since solv->recommendsruleq is null. Only call solver_addrecommendsrules if there are recommends rules. Signed-off-by: Alejandro del Castillo <[email protected]>
1 parent dc7d0f1 commit 19d7cc8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/solver.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3920,7 +3920,7 @@ solver_solve(Solver *solv, Queue *job)
39203920
else
39213921
solv->yumobsrules = solv->yumobsrules_end = solv->nrules;
39223922

3923-
if (solv->havedisfavored && solv->strongrecommends)
3923+
if (solv->havedisfavored && solv->strongrecommends && solv->recommendsruleq)
39243924
solver_addrecommendsrules(solv);
39253925
else
39263926
solv->recommendsrules = solv->recommendsrules_end = solv->nrules;

0 commit comments

Comments
 (0)