Skip to content

Commit 15a6088

Browse files
committed
windows fixes
1 parent 5e1ac6a commit 15a6088

6 files changed

Lines changed: 29 additions & 12 deletions

File tree

ext/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,9 @@ IF (WIN32)
162162
ENDIF ()
163163

164164
SET_TARGET_PROPERTIES(libsolvext PROPERTIES OUTPUT_NAME "solvext")
165+
if (MSVC AND DISABLE_SHARED AND ENABLE_STATIC)
166+
SET_TARGET_PROPERTIES(libsolvext PROPERTIES OUTPUT_NAME "solvext_static")
167+
endif()
165168
SET_TARGET_PROPERTIES(libsolvext PROPERTIES SOVERSION ${LIBSOLVEXT_SOVERSION})
166169

167170
INSTALL (FILES ${libsolvext_HEADERS} DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/solv")

src/CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,10 @@ IF (WIN32)
6262
ENDIF (WIN32)
6363

6464
SET_TARGET_PROPERTIES(libsolv PROPERTIES OUTPUT_NAME "solv")
65+
if (MSVC AND DISABLE_SHARED AND ENABLE_STATIC)
66+
SET_TARGET_PROPERTIES(libsolv PROPERTIES OUTPUT_NAME "solv_static")
67+
endif()
68+
6569
SET_TARGET_PROPERTIES(libsolv PROPERTIES SOVERSION ${LIBSOLV_SOVERSION})
6670

6771
INSTALL (FILES ${libsolv_HEADERS} DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/solv")

src/repo_write.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ write_compressed_blob(Repodata *data, void *blob, int len)
188188
write_u8(data, clen);
189189
write_blob(data, cpage, clen);
190190
}
191-
blob += chunk;
191+
blob = (char*) blob + chunk;
192192
len -= chunk;
193193
}
194194
}

src/solvversion.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77

88
#include "solvversion.h"
99

10-
const char solv_version[] = LIBSOLV_VERSION_STRING;
11-
int solv_version_major = LIBSOLV_VERSION_MAJOR;
12-
int solv_version_minor = LIBSOLV_VERSION_MINOR;
13-
int solv_version_patch = LIBSOLV_VERSION_PATCH;
14-
const char solv_toolversion[] = LIBSOLV_TOOLVERSION;
10+
SOLV_API const char solv_version[] = LIBSOLV_VERSION_STRING;
11+
SOLV_API int solv_version_major = LIBSOLV_VERSION_MAJOR;
12+
SOLV_API int solv_version_minor = LIBSOLV_VERSION_MINOR;
13+
SOLV_API int solv_version_patch = LIBSOLV_VERSION_PATCH;
14+
SOLV_API const char solv_toolversion[] = LIBSOLV_TOOLVERSION;

src/solvversion.h.in

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,18 @@
1919
#define LIBSOLV_VERSION_PATCH @LIBSOLV_PATCH@
2020
#define LIBSOLV_VERSION (LIBSOLV_VERSION_MAJOR * 10000 + LIBSOLV_VERSION_MINOR * 100 + LIBSOLV_VERSION_PATCH)
2121

22-
extern const char solv_version[];
23-
extern int solv_version_major;
24-
extern int solv_version_minor;
25-
extern int solv_version_patch;
26-
extern const char solv_toolversion[];
22+
#ifdef _WIN32
23+
// include win32/config.h for SOLV_API
24+
#include "config.h"
25+
#else
26+
#define SOLV_API
27+
#endif
28+
29+
SOLV_API extern const char solv_version[];
30+
SOLV_API extern int solv_version_major;
31+
SOLV_API extern int solv_version_minor;
32+
SOLV_API extern int solv_version_patch;
33+
SOLV_API extern const char solv_toolversion[];
2734

2835
#cmakedefine LIBSOLV_FEATURE_LINKED_PKGS
2936
#cmakedefine LIBSOLV_FEATURE_COMPLEX_DEPS

win32/CMakeLists.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
INCLUDE_DIRECTORIES (${PROJECT_SOURCE_DIR}/win32)
2+
23
SET (WIN32_COMPAT_SOURCES
34
${PROJECT_SOURCE_DIR}/win32/fnmatch.c
45
${PROJECT_SOURCE_DIR}/win32/getopt.c
56
${PROJECT_SOURCE_DIR}/win32/regcomp.c
67
${PROJECT_SOURCE_DIR}/win32/regexec.c
78
${PROJECT_SOURCE_DIR}/win32/strfncs.c
89
${PROJECT_SOURCE_DIR}/win32/tre-mem.c
9-
)
10+
)
11+
12+
INSTALL (FILES ${PROJECT_SOURCE_DIR}/win32/config.h DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/solv")

0 commit comments

Comments
 (0)