test: add tests

Author: navinkarkera

src/library-authoring/import-course/stepper/ImportStepperPage.test.tsx

@@ -159,7 +159,7 @@ describe('<ImportStepperModal />', () => {
     expect(courseCard).toBeChecked();
   });
 
-  it('should import select course on button click', async () => {
+  it('should import selected course on button click', async () => {
     (useGetBlockTypes as jest.Mock).mockReturnValue({
       isPending: false,
       data: {

src/library-authoring/import-course/stepper/ReviewImportDetails.test.tsx

@@ -1,6 +1,6 @@
 import { useCourseDetails } from '@src/course-outline/data/apiHooks';
 import { useMigrationInfo } from '@src/library-authoring/data/apiHooks';
-import { useGetBlockTypes } from '@src/search-manager';
+import { useGetBlockTypes, useGetContentHits } from '@src/search-manager';
 import { render as baseRender, screen, initializeMocks } from '@src/testUtils';
 import { LibraryProvider } from '@src/library-authoring/common/context/LibraryContext';
 import { mockContentLibrary } from '@src/library-authoring/data/api.mocks';
@@ -25,6 +25,7 @@ jest.mock('@src/library-authoring/data/apiHooks', () => ({
 // Mock the useGetBlockTypes hook
 jest.mock('@src/search-manager', () => ({
   useGetBlockTypes: jest.fn().mockReturnValue({ isPending: true, data: null }),
+  useGetContentHits: jest.fn().mockReturnValue({ isPending: true, data: null }),
 }));
 
 const render = (element: React.ReactElement) => {
@@ -80,7 +81,7 @@ describe('ReviewImportDetails', () => {
         }],
       },
     });
-    (useGetBlockTypes as jest.Mock).mockReturnValue({
+    (useGetBlockTypes as jest.Mock).mockReturnValueOnce({
       isPending: false,
       data: { html: 1 },
     });
@@ -103,7 +104,7 @@ describe('ReviewImportDetails', () => {
       isPending: false,
       data: null,
     });
-    (useGetBlockTypes as jest.Mock).mockReturnValue({
+    (useGetBlockTypes as jest.Mock).mockReturnValueOnce({
       isPending: false,
       data: {
         chapter: 1,
@@ -134,13 +135,63 @@ describe('ReviewImportDetails', () => {
     expect(markAnalysisComplete).toHaveBeenCalledWith(true);
   });
 
+  it('considers children blocks of unsupportedBlocks', async () => {
+    (useCourseDetails as jest.Mock).mockReturnValue({ isPending: false, data: { title: 'Test Course' } });
+    (useMigrationInfo as jest.Mock).mockReturnValue({
+      isPending: false,
+      data: null,
+    });
+    (useGetContentHits as jest.Mock).mockReturnValue({
+      isPending: false,
+      data: {
+        hits: [{usage_key: "some-usage-key"}],
+        estimatedTotalHits: 1,
+      },
+    });
+    (useGetBlockTypes as jest.Mock).mockReturnValueOnce({
+      isPending: false,
+      data: {
+        chapter: 1,
+        sequential: 2,
+        vertical: 3,
+        library_content: 1,
+        html: 1,
+        problem: 4,
+      },
+    }).mockReturnValueOnce({
+      isPending: false,
+      data: {
+        problem: 2,
+      },
+    });
+
+    render(<ReviewImportDetails markAnalysisComplete={markAnalysisComplete} courseId="test-course-id" />);
+
+    expect(await screen.findByRole('alert')).toBeInTheDocument();
+    expect(await screen.findByText(/Import Analysis Complete/i)).toBeInTheDocument();
+    expect(await screen.findByText(
+      /25.00% of content cannot be imported. For details see below./i,
+    )).toBeInTheDocument();
+    expect(await screen.findByText(/Total Blocks/i)).toBeInTheDocument();
+    expect(await screen.findByText('9/12')).toBeInTheDocument();
+    expect(await screen.findByText('Sections')).toBeInTheDocument();
+    expect(await screen.findByText('1')).toBeInTheDocument();
+    expect(await screen.findByText('Subsections')).toBeInTheDocument();
+    expect(await screen.findByText('2')).toBeInTheDocument();
+    expect(await screen.findByText('Units')).toBeInTheDocument();
+    expect(await screen.findByText('3')).toBeInTheDocument();
+    expect(await screen.findByText('Components')).toBeInTheDocument();
+    expect(await screen.findByText('3/6')).toBeInTheDocument();
+    expect(markAnalysisComplete).toHaveBeenCalledWith(true);
+  });
+
   it('renders success alert when no unsupported blocks', async () => {
     (useCourseDetails as jest.Mock).mockReturnValue({ isPending: false, data: { title: 'Test Course' } });
     (useMigrationInfo as jest.Mock).mockReturnValue({
       isPending: false,
       data: null,
     });
-    (useGetBlockTypes as jest.Mock).mockReturnValue({
+    (useGetBlockTypes as jest.Mock).mockReturnValueOnce({
       isPending: false,
       data: {
         chapter: 1,

src/library-authoring/import-course/stepper/ReviewImportDetails.tsx

@@ -8,10 +8,9 @@ import { useEffect, useMemo } from 'react';
 import { CheckCircle, Warning } from '@openedx/paragon/icons';
 import { useLibraryContext } from '@src/library-authoring/common/context/LibraryContext';
 import { useMigrationInfo } from '@src/library-authoring/data/apiHooks';
-import { useGetBlockTypes } from '@src/search-manager';
+import { useGetBlockTypes, useGetContentHits } from '@src/search-manager';
 import { SummaryCard } from './SummaryCard';
 import messages from '../messages';
-import { useGetContentHits } from '../../../search-manager/data/apiHooks';
 
 interface Props {
   courseId?: string;
@@ -141,10 +140,16 @@ export const ReviewImportDetails = ({ courseId, markAnalysisComplete }: Props) =
     return unsupportedBlocks;
   }, [unsupportedBlockTypes]);
 
-  const { data: unsupportedBlocksData } = useGetContentHits([
-    `context_key = "${courseId}"`,
-    `block_type IN [${unsupportedBlockTypes?.flatMap(([value]) => `"${value}"`).join(',')}]`,
-  ], totalUnsupportedBlocks > 0, totalUnsupportedBlocks, 'always');
+  const { data: unsupportedBlocksData } = useGetContentHits(
+    [
+      `context_key = "${courseId}"`,
+      `block_type IN [${unsupportedBlockTypes?.flatMap(([ value ]) => `"${value}"`).join(',')}]`,
+    ],
+    totalUnsupportedBlocks > 0,
+    [ "usage_key" ],
+    totalUnsupportedBlocks,
+    'always'
+  );
 
   const { data: unsupportedBlocksChildren } = useGetBlockTypes([
     `context_key = "${courseId}"`,

src/search-manager/data/api.ts

@@ -561,13 +561,15 @@ export const fetchContentHits = async (
   indexName: string,
   extraFilter?: Filter,
   limit?: number,
+  attributesToRetrieve?: string[],
 ): Promise<SearchResponse<Record<string, any>>> => {
   // Convert 'extraFilter' into an array
   const extraFilterFormatted = forceArray(extraFilter);
 
   const results = await client.index(indexName).search('', {
     filter: extraFilterFormatted,
     limit,
+    attributesToRetrieve,
   });
 
   return results;

src/search-manager/data/apiHooks.ts

@@ -309,6 +309,7 @@ export const useGetBlockTypes = (extraFilters: Filter, enabled: boolean = true)
 export const useGetContentHits = (
   extraFilters: Filter,
   enabled: boolean = true,
+  attributesToRetrieve?: string[],
   limit?: number,
   refetchOnMount?: boolean | 'always',
 ) => {
@@ -322,7 +323,13 @@ export const useGetContentHits = (
       indexName,
       extraFilters,
     ],
-    queryFn: enabled ? () => fetchContentHits(client!, indexName!, extraFilters, limit) : skipToken,
+    queryFn: enabled ? () => fetchContentHits(
+      client!,
+      indexName!,
+      extraFilters,
+      limit,
+      attributesToRetrieve,
+    ) : skipToken,
     refetchOnMount,
   });
 };

src/search-manager/index.ts

@@ -13,6 +13,7 @@ export {
   useContentSearchConnection,
   useContentSearchResults,
   useGetBlockTypes,
+  useGetContentHits,
   buildSearchQueryKey,
 } from './data/apiHooks';
 export { TypesFilterData } from './hooks';